diff options
| author | esprehn <esprehn@chromium.org> | 2016-03-21 17:41:05 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-22 00:43:15 +0000 |
| commit | 0ebf9a924d744ef98948ecb4f5d9e9a6fd3b42bf (patch) | |
| tree | 36f47266a3c2cd6768fe0aa0a8a329096679c3eb /mojo/shell/background/tests | |
| parent | 5ee3f242cefebba7eb0f05424e7308f9158d8388 (diff) | |
| download | chromium_src-0ebf9a924d744ef98948ecb4f5d9e9a6fd3b42bf.zip chromium_src-0ebf9a924d744ef98948ecb4f5d9e9a6fd3b42bf.tar.gz chromium_src-0ebf9a924d744ef98948ecb4f5d9e9a6fd3b42bf.tar.bz2 | |
Revert of Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used (patchset #2 id:20001 of https://codereview.chromium.org/1819063002/ )
Reason for revert:
Looks like to made the mojo_apptests go red. I think this is also making MUS tests fail?
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/39128
Original issue's description:
> Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used
>
> This was originally at https://codereview.chromium.org/1814223002/ , but Ben is out and
> I need this for tests, so I'm taking over.
>
> BUG=none
> TEST=covered by tests
> TBR=ben@chromium.org
> R=ben@chromium.org
>
> Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b
> Cr-Commit-Position: refs/heads/master@{#382389}
TBR=ben@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/1821913002
Cr-Commit-Position: refs/heads/master@{#382460}
Diffstat (limited to 'mojo/shell/background/tests')
| -rw-r--r-- | mojo/shell/background/tests/test_service.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mojo/shell/background/tests/test_service.cc b/mojo/shell/background/tests/test_service.cc index e69640d..d030a81 100644 --- a/mojo/shell/background/tests/test_service.cc +++ b/mojo/shell/background/tests/test_service.cc @@ -25,8 +25,8 @@ class TestClient : public ShellClient, connection->AddInterface(this); return true; } - bool ShellConnectionLost() override { - return true; + void ShellConnectionLost() override { + base::MessageLoop::current()->QuitWhenIdle(); } // InterfaceFactory<mojom::TestService>: |