diff options
| author | rockot <rockot@chromium.org> | 2016-03-13 16:42:41 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-13 23:43:39 +0000 |
| commit | 35f7270e84da5abb0f7895304a53d632efbbfe71 (patch) | |
| tree | 020089f6fb8b68dcefac3defefeba50bccbb54c2 /mojo/shell/background/tests | |
| parent | f749fe6715f1f3c81bda3576fd60f260ac47282a (diff) | |
| download | chromium_src-35f7270e84da5abb0f7895304a53d632efbbfe71.zip chromium_src-35f7270e84da5abb0f7895304a53d632efbbfe71.tar.gz chromium_src-35f7270e84da5abb0f7895304a53d632efbbfe71.tar.bz2 | |
Remove ShellConnection::WaitForInitialize
This changes ShellClient::Initialize to expect a
response with an optional Connector request rather
than a ConnectorPtr being passed in with the call.
This allows clients to create their own Connector
pipe and lazily connect it to the shell thus
avoiding any practical need to wait for an
Initialize message.
Additionally:
- Client instances no longer die on the first
Connector pipe error: instead an Instance is
kept alive by the shell as long as either the
ShellClient pipe is connected OR any Connector
pipes are connected.
- ShellClientFactory endpoints are now strongly
typed instead of being raw message pipe
handles.
- Some uses of MessagePumpMojo near other changes
in this CL have been opportunistically removed.
BUG=591742
Review URL: https://codereview.chromium.org/1793793002
Cr-Commit-Position: refs/heads/master@{#380909}
Diffstat (limited to 'mojo/shell/background/tests')
| -rw-r--r-- | mojo/shell/background/tests/background_shell_unittest.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/mojo/shell/background/tests/background_shell_unittest.cc b/mojo/shell/background/tests/background_shell_unittest.cc index 82b36b1..8901ab3 100644 --- a/mojo/shell/background/tests/background_shell_unittest.cc +++ b/mojo/shell/background/tests/background_shell_unittest.cc @@ -57,7 +57,6 @@ TEST(BackgroundShellTest, MAYBE_Basic) { ShellClientImpl shell_client; ShellConnection shell_connection( &shell_client, background_shell.CreateShellClientRequest(kTestName)); - shell_connection.WaitForInitialize(); mojom::TestServicePtr test_service; shell_connection.connector()->ConnectToInterface( "mojo:background_shell_test_app", &test_service); |