diff options
| author | yzshen <yzshen@chromium.org> | 2016-03-10 17:03:10 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-11 01:04:52 +0000 |
| commit | 080cd66aa15c526bdb5b8363e21599598f5c0303 (patch) | |
| tree | 0f72e705dda192efd8b33647f58e16bc05563d47 /mojo/shell | |
| parent | 87a54081565d15fd55f9e6b2af521360fb15eff3 (diff) | |
| download | chromium_src-080cd66aa15c526bdb5b8363e21599598f5c0303.zip chromium_src-080cd66aa15c526bdb5b8363e21599598f5c0303.tar.gz chromium_src-080cd66aa15c526bdb5b8363e21599598f5c0303.tar.bz2 | |
Revert of Reland: Mojo C++ bindings: replace '::' with '.' in the interface name. (patchset #2 id:20001 of https://codereview.chromium.org/1782543004/ )
Reason for revert:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/33342
Original issue's description:
> Reland: Mojo C++ bindings: replace '::' with '.' in the interface name.
>
> Previously the |foo::Bar::Name_| field was "foo::Bar". With this change it
> becomes "foo.Bar".
>
> Using C++-style namespace in the name doesn't makes too much sense because the
> name should remain the same across different languages.
>
> The original CL was https://codereview.chromium.org/1778793004/
>
> BUG=None
> TBR=ben@chromium.org
>
> Committed: https://crrev.com/a061a917ebc0d16fb67d2644d93bfdca7eec92d3
> Cr-Commit-Position: refs/heads/master@{#380459}
TBR=ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/1785803003
Cr-Commit-Position: refs/heads/master@{#380503}
Diffstat (limited to 'mojo/shell')
| -rw-r--r-- | mojo/shell/tests/connect/connect_unittests_manifest.json | 8 | ||||
| -rw-r--r-- | mojo/shell/tests/shell/target_manifest.json | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/mojo/shell/tests/connect/connect_unittests_manifest.json b/mojo/shell/tests/connect/connect_unittests_manifest.json index a36e640..cb8e865 100644 --- a/mojo/shell/tests/connect/connect_unittests_manifest.json +++ b/mojo/shell/tests/connect/connect_unittests_manifest.json @@ -3,9 +3,9 @@ "display_name": "Connect Unittests", "capabilities": { "mojo:connect_test_package": ["*"], - "mojo:connect_test_app": ["mojo.shell.test.mojom.ConnectTestService", - "mojo.shell.test.mojom.StandaloneApp"], - "mojo:connect_test_a": ["mojo.shell.test.mojom.ConnectTestService", - "mojo.shell.test.mojom.StandaloneApp"] + "mojo:connect_test_app": ["mojo::shell::test::mojom::ConnectTestService", + "mojo::shell::test::mojom::StandaloneApp"], + "mojo:connect_test_a": ["mojo::shell::test::mojom::ConnectTestService", + "mojo::shell::test::mojom::StandaloneApp"] } } diff --git a/mojo/shell/tests/shell/target_manifest.json b/mojo/shell/tests/shell/target_manifest.json index f751592..68ddc21 100644 --- a/mojo/shell/tests/shell/target_manifest.json +++ b/mojo/shell/tests/shell/target_manifest.json @@ -1,5 +1,5 @@ { "name": "exe:shell_unittest_target", "display_name": "Shell Unittest: Target", - "capabilities": { "mojo:shell_unittest": [ "mojo.shell.test.mojom.CreateInstanceTest" ] } + "capabilities": { "mojo:shell_unittest": [ "mojo::shell::test::mojom::CreateInstanceTest" ] } } |