summaryrefslogtreecommitdiffstats
path: root/mojo/shell
diff options
context:
space:
mode:
authoryzshen <yzshen@chromium.org>2016-02-24 23:29:27 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-25 07:30:23 +0000
commitd414dc34a7f87a2000e09c58b9ddbb5bd6b61463 (patch)
treea9ec402cbfbef1da3acde6071d992e2ade92ca8b /mojo/shell
parentd910911b407efde31709e3a766a5ee776db4c626 (diff)
downloadchromium_src-d414dc34a7f87a2000e09c58b9ddbb5bd6b61463.zip
chromium_src-d414dc34a7f87a2000e09c58b9ddbb5bd6b61463.tar.gz
chromium_src-d414dc34a7f87a2000e09c58b9ddbb5bd6b61463.tar.bz2
Rename WeakBindingSet/WeakInterfacePtrSet to BindingSet/InterfacePtrSet.
This CL also renames the element type (WeakBinding/WeakInterfacePtr) to Element and hide them in the corresonding *Set class. BUG=None CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/632d319842096e6998d174e2f251865979ce2b72 Cr-Commit-Position: refs/heads/master@{#377384} Review URL: https://codereview.chromium.org/1735583002 Cr-Commit-Position: refs/heads/master@{#377528}
Diffstat (limited to 'mojo/shell')
-rw-r--r--mojo/shell/application_instance.h4
-rw-r--r--mojo/shell/application_manager.h8
-rw-r--r--mojo/shell/background/tests/test_service.cc4
-rw-r--r--mojo/shell/runner/child/native_apptest_target.cc4
-rw-r--r--mojo/shell/tests/application_manager_apptest.cc2
-rw-r--r--mojo/shell/tests/application_manager_apptest_driver.cc4
-rw-r--r--mojo/shell/tests/capability_filter_test.cc8
-rw-r--r--mojo/shell/tests/package_test_package.cc8
8 files changed, 21 insertions, 21 deletions
diff --git a/mojo/shell/application_instance.h b/mojo/shell/application_instance.h
index d5654dc..4599137 100644
--- a/mojo/shell/application_instance.h
+++ b/mojo/shell/application_instance.h
@@ -14,7 +14,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/process/process_handle.h"
#include "mojo/public/cpp/bindings/binding.h"
-#include "mojo/public/cpp/bindings/weak_binding_set.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/shell/connect_params.h"
#include "mojo/shell/identity.h"
#include "mojo/shell/public/interfaces/application_manager.mojom.h"
@@ -91,7 +91,7 @@ class ApplicationInstance : public mojom::Shell,
mojom::ShellClientPtr shell_client_;
Binding<mojom::Shell> binding_;
Binding<mojom::PIDReceiver> pid_receiver_binding_;
- WeakBindingSet<mojom::Connector> connectors_;
+ BindingSet<mojom::Connector> connectors_;
bool queue_requests_;
std::vector<ConnectParams*> queued_client_requests_;
NativeRunner* native_runner_;
diff --git a/mojo/shell/application_manager.h b/mojo/shell/application_manager.h
index 2757d92..fb1763b 100644
--- a/mojo/shell/application_manager.h
+++ b/mojo/shell/application_manager.h
@@ -11,8 +11,8 @@
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
-#include "mojo/public/cpp/bindings/weak_binding_set.h"
-#include "mojo/public/cpp/bindings/weak_interface_ptr_set.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
+#include "mojo/public/cpp/bindings/interface_ptr_set.h"
#include "mojo/services/package_manager/package_manager.h"
#include "mojo/services/package_manager/public/interfaces/shell_resolver.mojom.h"
#include "mojo/shell/application_loader.h"
@@ -186,14 +186,14 @@ class ApplicationManager : public ShellClient,
// Counter used to assign ids to content handlers.
uint32_t shell_client_factory_id_counter_;
- WeakInterfacePtrSet<mojom::ApplicationManagerListener> listeners_;
+ InterfacePtrSet<mojom::ApplicationManagerListener> listeners_;
base::Callback<void(const Identity&)> instance_quit_callback_;
base::TaskRunner* file_task_runner_;
scoped_ptr<NativeRunnerFactory> native_runner_factory_;
std::vector<scoped_ptr<NativeRunner>> native_runners_;
scoped_ptr<ShellConnection> shell_connection_;
- WeakBindingSet<mojom::ApplicationManager> bindings_;
+ BindingSet<mojom::ApplicationManager> bindings_;
base::WeakPtrFactory<ApplicationManager> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(ApplicationManager);
diff --git a/mojo/shell/background/tests/test_service.cc b/mojo/shell/background/tests/test_service.cc
index 3c9dbbd..4d001af 100644
--- a/mojo/shell/background/tests/test_service.cc
+++ b/mojo/shell/background/tests/test_service.cc
@@ -3,7 +3,7 @@
// found in the LICENSE file.
#include "mojo/public/c/system/main.h"
-#include "mojo/public/cpp/bindings/weak_binding_set.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/shell/background/tests/test.mojom.h"
#include "mojo/shell/public/cpp/application_runner.h"
#include "mojo/shell/public/cpp/connection.h"
@@ -39,7 +39,7 @@ class TestClient : public ShellClient,
// mojom::TestService
void Test(const TestCallback& callback) override { callback.Run(); }
- WeakBindingSet<mojom::TestService> bindings_;
+ BindingSet<mojom::TestService> bindings_;
DISALLOW_COPY_AND_ASSIGN(TestClient);
};
diff --git a/mojo/shell/runner/child/native_apptest_target.cc b/mojo/shell/runner/child/native_apptest_target.cc
index d2747c5..04ebdbb 100644
--- a/mojo/shell/runner/child/native_apptest_target.cc
+++ b/mojo/shell/runner/child/native_apptest_target.cc
@@ -7,7 +7,7 @@
#include "base/at_exit.h"
#include "base/command_line.h"
#include "base/macros.h"
-#include "mojo/public/cpp/bindings/weak_binding_set.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/shell/public/cpp/connection.h"
#include "mojo/shell/public/cpp/interface_factory.h"
#include "mojo/shell/public/cpp/shell.h"
@@ -47,7 +47,7 @@ class TargetApplicationDelegate
bindings_.AddBinding(this, std::move(request));
}
- mojo::WeakBindingSet<mojo::shell::test::TestNativeService> bindings_;
+ mojo::BindingSet<mojo::shell::test::TestNativeService> bindings_;
DISALLOW_COPY_AND_ASSIGN(TargetApplicationDelegate);
};
diff --git a/mojo/shell/tests/application_manager_apptest.cc b/mojo/shell/tests/application_manager_apptest.cc
index 9ebc076..82fa8bc 100644
--- a/mojo/shell/tests/application_manager_apptest.cc
+++ b/mojo/shell/tests/application_manager_apptest.cc
@@ -11,7 +11,7 @@
#include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/process/process_handle.h"
-#include "mojo/public/cpp/bindings/weak_binding_set.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/shell/public/cpp/application_test_base.h"
#include "mojo/shell/public/cpp/interface_factory.h"
#include "mojo/shell/public/cpp/shell.h"
diff --git a/mojo/shell/tests/application_manager_apptest_driver.cc b/mojo/shell/tests/application_manager_apptest_driver.cc
index aad9660..2a820fe 100644
--- a/mojo/shell/tests/application_manager_apptest_driver.cc
+++ b/mojo/shell/tests/application_manager_apptest_driver.cc
@@ -21,7 +21,7 @@
#include "mojo/edk/embedder/embedder.h"
#include "mojo/edk/embedder/platform_channel_pair.h"
#include "mojo/edk/embedder/scoped_platform_handle.h"
-#include "mojo/public/cpp/bindings/weak_binding_set.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/shell/public/cpp/connection.h"
#include "mojo/shell/public/cpp/interface_factory.h"
#include "mojo/shell/public/cpp/shell.h"
@@ -136,7 +136,7 @@ class TargetApplicationDelegate : public mojo::ShellClient,
mojo::Shell* shell_;
base::Process target_;
- mojo::WeakBindingSet<Driver> bindings_;
+ mojo::BindingSet<Driver> bindings_;
base::WeakPtrFactory<TargetApplicationDelegate> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(TargetApplicationDelegate);
diff --git a/mojo/shell/tests/capability_filter_test.cc b/mojo/shell/tests/capability_filter_test.cc
index 32257ee..3fac67c 100644
--- a/mojo/shell/tests/capability_filter_test.cc
+++ b/mojo/shell/tests/capability_filter_test.cc
@@ -9,8 +9,8 @@
#include "base/macros.h"
#include "base/stl_util.h"
#include "base/strings/stringprintf.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/public/cpp/bindings/strong_binding.h"
-#include "mojo/public/cpp/bindings/weak_binding_set.h"
#include "mojo/services/package_manager/package_manager.h"
#include "mojo/shell/application_loader.h"
#include "mojo/shell/public/cpp/connection.h"
@@ -98,7 +98,7 @@ class ConnectionValidator : public ApplicationLoader,
std::set<std::string> expectations_;
std::set<std::string> unexpected_;
base::MessageLoop* loop_;
- WeakBindingSet<Validator> validator_bindings_;
+ BindingSet<Validator> validator_bindings_;
DISALLOW_COPY_AND_ASSIGN(ConnectionValidator);
};
@@ -151,8 +151,8 @@ class ServiceApplication : public ShellClient,
Shell* shell_;
ValidatorPtr validator_;
- WeakBindingSet<Safe> safe_bindings_;
- WeakBindingSet<Unsafe> unsafe_bindings_;
+ BindingSet<Safe> safe_bindings_;
+ BindingSet<Unsafe> unsafe_bindings_;
DISALLOW_COPY_AND_ASSIGN(ServiceApplication);
};
diff --git a/mojo/shell/tests/package_test_package.cc b/mojo/shell/tests/package_test_package.cc
index a9defe4..ee8ff5b 100644
--- a/mojo/shell/tests/package_test_package.cc
+++ b/mojo/shell/tests/package_test_package.cc
@@ -12,7 +12,7 @@
#include "base/run_loop.h"
#include "base/threading/simple_thread.h"
#include "mojo/public/c/system/main.h"
-#include "mojo/public/cpp/bindings/weak_binding_set.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/shell/public/cpp/application_runner.h"
#include "mojo/shell/public/cpp/interface_factory.h"
#include "mojo/shell/public/cpp/shell.h"
@@ -88,7 +88,7 @@ class ProvidedShellClient
const std::string name_;
mojom::ShellClientRequest request_;
Shell* shell_;
- WeakBindingSet<test::mojom::PackageTestService> bindings_;
+ BindingSet<test::mojom::PackageTestService> bindings_;
DISALLOW_COPY_AND_ASSIGN(ProvidedShellClient);
};
@@ -151,8 +151,8 @@ class PackageTestShellClient
Shell* shell_;
std::vector<scoped_ptr<ShellClient>> delegates_;
- WeakBindingSet<mojom::ShellClientFactory> shell_client_factory_bindings_;
- WeakBindingSet<test::mojom::PackageTestService> bindings_;
+ BindingSet<mojom::ShellClientFactory> shell_client_factory_bindings_;
+ BindingSet<test::mojom::PackageTestService> bindings_;
DISALLOW_COPY_AND_ASSIGN(PackageTestShellClient);
};