diff options
| author | dcheng <dcheng@chromium.org> | 2015-12-14 11:24:42 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-14 19:25:36 +0000 |
| commit | 3777a456451ab42f94e1dc29c9f52a03c7a312fe (patch) | |
| tree | 607a015c9012a1968988d3e12ba86cdead218502 /mojo | |
| parent | e2ca0c18f40c746cafc2bb594bd5d8b06341cb1b (diff) | |
| download | chromium_src-3777a456451ab42f94e1dc29c9f52a03c7a312fe.zip chromium_src-3777a456451ab42f94e1dc29c9f52a03c7a312fe.tar.gz chromium_src-3777a456451ab42f94e1dc29c9f52a03c7a312fe.tar.bz2 | |
Revert of Only set -rpath=$ORIGIN in component builds by default. (patchset #3 id:40001 of https://codereview.chromium.org/1514203002/ )
Reason for revert:
Breaks Linux GN components_browsertests:
components_browsertests: error while loading shared libraries: libblink_test_plugin.so: cannot open shared object file: No such file or directory
Original issue's description:
> Only set -rpath=$ORIGIN in component builds by default.
>
> Statically-linked binaries do not need -rpath=$ORIGIN
> set, and setting it can be a source of strange security
> issues (see bug for more details).
>
> Manually add this to some test binaries that require shared libraries to be loaded from the build directory.
>
> R=phajdan.jr@chromium.org, thestig@chromium.org
> BUG=556843
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng
>
> Forked from http://crrev.com/1448213002
>
> Committed: https://crrev.com/3de132ceb95eb0d1fd40b611374d6868c717d2b4
> Cr-Commit-Position: refs/heads/master@{#364877}
TBR=phajdan.jr@chromium.org,dpranke@chromium.org,thestig@chromium.org,jam@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=556843
Review URL: https://codereview.chromium.org/1525733002
Cr-Commit-Position: refs/heads/master@{#365068}
Diffstat (limited to 'mojo')
| -rw-r--r-- | mojo/common/BUILD.gn | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/mojo/common/BUILD.gn b/mojo/common/BUILD.gn index f2da1fc..7cbd5bf4 100644 --- a/mojo/common/BUILD.gn +++ b/mojo/common/BUILD.gn @@ -97,12 +97,6 @@ test("mojo_common_unittests") { "../message_pump/message_pump_mojo_unittest.cc", "common_type_converters_unittest.cc", ] - - if (is_linux && !is_component_build) { - # This tests dynamically loads libmojo_test_support even in non-component - # builds. - configs += [ "//build/config/gcc:rpath_for_built_shared_libraries" ] - } } test("mojo_common_perftests") { |