diff options
| author | rockot <rockot@chromium.org> | 2016-03-09 08:38:10 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-09 16:39:28 +0000 |
| commit | 4eb9c5a2fbceeb0e67dade6a5e48639fd0795254 (patch) | |
| tree | 137f2e9b5a604832a4a269a93427ee147f3a610f /mojo | |
| parent | 6aacb58a448d503715acff53cea8abe86f51aea2 (diff) | |
| download | chromium_src-4eb9c5a2fbceeb0e67dade6a5e48639fd0795254.zip chromium_src-4eb9c5a2fbceeb0e67dade6a5e48639fd0795254.tar.gz chromium_src-4eb9c5a2fbceeb0e67dade6a5e48639fd0795254.tar.bz2 | |
Fix public_deps for shell runner host
Build flake:
https://build.chromium.org/p/chromium/builders/Linux/builds/72756/steps/compile/logs/stdio
If targets depend on //foo and include //foo/foo.h, and //foo depends on //bar and
//foo/foo.h includes //bar/bar.h, then //bar must be in //foo's public_deps. If
bar.h is a generated header, getting this wrong = build flake when building //foo's
dependent targets.
TBR=ben@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1777933002
Cr-Commit-Position: refs/heads/master@{#380146}
Diffstat (limited to 'mojo')
| -rw-r--r-- | mojo/shell/runner/host/BUILD.gn | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/mojo/shell/runner/host/BUILD.gn b/mojo/shell/runner/host/BUILD.gn index f7b4538..67066af 100644 --- a/mojo/shell/runner/host/BUILD.gn +++ b/mojo/shell/runner/host/BUILD.gn @@ -69,19 +69,23 @@ source_set("lib") { deps = [ ":child_process_base", ":native_application_support", - "//base", "//base:base_static", "//base:i18n", - "//mojo/edk/system", "//mojo/message_pump", "//mojo/platform_handle:platform_handle_impl", - "//mojo/shell", "//mojo/shell/public/cpp:sources", - "//mojo/shell/public/interfaces", "//mojo/shell/runner:init", "//mojo/shell/runner/common", ] + public_deps = [ + "//base", + "//mojo/edk/system", + "//mojo/public/cpp/system", + "//mojo/shell", + "//mojo/shell/public/interfaces", + ] + if (is_linux && !is_android) { sources += [ "linux_sandbox.cc", |