diff options
author | rdevlin.cronin <rdevlin.cronin@chromium.org> | 2014-09-29 12:46:58 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-09-29 19:47:58 +0000 |
commit | 4efc003eb10aba8c8189d831ec8825eb022c5b2c (patch) | |
tree | 97a4f0ca5aa88755b1262fca25417bc33490ff80 /mojo | |
parent | b83907e0384a25d8d10e5e15c564db4ec18f21bc (diff) | |
download | chromium_src-4efc003eb10aba8c8189d831ec8825eb022c5b2c.zip chromium_src-4efc003eb10aba8c8189d831ec8825eb022c5b2c.tar.gz chromium_src-4efc003eb10aba8c8189d831ec8825eb022c5b2c.tar.bz2 |
Make the chevron menu button responsible for legacy overflow menu logic
Move the ChevronMenuButton class into its own file, and move the logic to show
the legacy (drop-down) extension action overflow menu from the
BrowserActionsContainer into there.
This is mainly because:
1. We'll eventually be getting rid of this legacy behavior, and this way, the
removal is all concentrated in one area (ChevronMenuButton).
2. BrowserActionsContainer is already doing a ton (since it has both new
overflow and normal logic). It doesn't need this, too.
As a bonus, refactored the lifetime of the overflow menu to be more
deterministic, and got rid of the back-and-forth between it and the
BrowserActionsContainer.
And all with a negative line count! Woohoo!
BUG=417085
Review URL: https://codereview.chromium.org/597783002
Cr-Commit-Position: refs/heads/master@{#297240}
Diffstat (limited to 'mojo')
0 files changed, 0 insertions, 0 deletions