summaryrefslogtreecommitdiffstats
path: root/native_client_sdk/PRESUBMIT.py
diff options
context:
space:
mode:
authorsbc@chromium.org <sbc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-09-04 23:54:13 +0000
committersbc@chromium.org <sbc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-09-04 23:54:13 +0000
commit75e10ff7a912787dad8efe2b1d5b507b2da2a8ad (patch)
tree4b3e294f26f8afd070551d191afd593c9aa9ba6b /native_client_sdk/PRESUBMIT.py
parentfa8cd27dc1140c066622ba75786e6f345f21bf2e (diff)
downloadchromium_src-75e10ff7a912787dad8efe2b1d5b507b2da2a8ad.zip
chromium_src-75e10ff7a912787dad8efe2b1d5b507b2da2a8ad.tar.gz
chromium_src-75e10ff7a912787dad8efe2b1d5b507b2da2a8ad.tar.bz2
add PRESUBMIT for native_client_sdk.
Currently just does pylint. Fix many obvious lint errors (but not all by any means). BUG= Review URL: https://chromiumcodereview.appspot.com/10868089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154856 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'native_client_sdk/PRESUBMIT.py')
-rw-r--r--native_client_sdk/PRESUBMIT.py46
1 files changed, 46 insertions, 0 deletions
diff --git a/native_client_sdk/PRESUBMIT.py b/native_client_sdk/PRESUBMIT.py
new file mode 100644
index 0000000..1b711b9
--- /dev/null
+++ b/native_client_sdk/PRESUBMIT.py
@@ -0,0 +1,46 @@
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Top-level presubmit script for isolate.
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
+details on the presubmit API built into gcl.
+"""
+
+
+def CommonChecks(input_api, output_api):
+ output = []
+ disabled_warnings = [
+ 'R0401', # Cyclic import
+ 'W0613', # Unused argument
+ 'E1103', # subprocess.communicate() generates these :(
+ ]
+ black_list = [r'src/site_scons/.*',
+ r'.*/decode_dump.py',
+ r'src/build_tools/build_sdk.py',
+ r'src/build_tools/buildbot_common.py',
+ r'src/build_tools/buildbot_run.py',
+ r'src/build_tools/build_utils.py',
+ r'src/build_tools/build_updater.py',
+ r'src/build_tools/manifest_util.py',
+ r'src/build_tools/nacl*',
+ r'src/build_tools/generate_make.py',
+ r'src/build_tools/sdk_tools/sdk_update_main.py',
+ r'src/build_tools/sdk_tools/sdk_update.py',
+ r'src/project_templates',
+ r'.*/update_manifest.py',
+ r'.*/update_nacl_manifest.py',
+ r'src/build_tools/tests/.*']
+ canned = input_api.canned_checks
+ output.extend(canned.RunPylint(input_api, output_api, black_list=black_list,
+ disabled_warnings=disabled_warnings))
+ return output
+
+
+def CheckChangeOnUpload(input_api, output_api):
+ return CommonChecks(input_api, output_api)
+
+
+def CheckChangeOnCommit(input_api, output_api):
+ return CommonChecks(input_api, output_api)