diff options
| author | robliao@chromium.org <robliao@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-13 23:30:49 +0000 |
|---|---|---|
| committer | robliao@chromium.org <robliao@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-13 23:30:49 +0000 |
| commit | fd2afc24f952a795acfe81906b02ef1e7330d17d (patch) | |
| tree | dbb264ed28d50e12774f88830d6b6959c0610fd5 /native_client_sdk/src/libraries/nacl_io/mount_html5fs.h | |
| parent | c76fe6734b1b5e4985828c634e582063b0267eb9 (diff) | |
| download | chromium_src-fd2afc24f952a795acfe81906b02ef1e7330d17d.zip chromium_src-fd2afc24f952a795acfe81906b02ef1e7330d17d.tar.gz chromium_src-fd2afc24f952a795acfe81906b02ef1e7330d17d.tar.bz2 | |
Chrome Now notificationGroups Storage Race Condition Fix
Updating cards involves updating the notificationGroups in rapid succession,
leading to race conditions between storage.get and storage.set. The queued
up storage.gets may dispatch all at once before each storage.set, meaning that
the storage.set will set stale values.
In other words, we get
storage.get
storage.get
storage.set
storage.set
instead of
storage.get
storage.set
storage.get
storage.set
The fix here is to move the requests outside of the for loop, adding
arguments to functions where necessary to work around this gotcha.
BUG=164227
Review URL: https://codereview.chromium.org/114533002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240798 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'native_client_sdk/src/libraries/nacl_io/mount_html5fs.h')
0 files changed, 0 insertions, 0 deletions