diff options
author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-28 22:52:19 +0000 |
---|---|---|
committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-28 22:52:19 +0000 |
commit | bba9e63bdb8de860a20f2979c49cb814552d3ee3 (patch) | |
tree | 85fb36329ca1fa9dcbca6bbf8090ef80b1c7b466 /native_client_sdk/src/tools | |
parent | 28b6d3554a56f6611b74bad1e1baf24e38ec7070 (diff) | |
download | chromium_src-bba9e63bdb8de860a20f2979c49cb814552d3ee3.zip chromium_src-bba9e63bdb8de860a20f2979c49cb814552d3ee3.tar.gz chromium_src-bba9e63bdb8de860a20f2979c49cb814552d3ee3.tar.bz2 |
Misc. cleanup:
* Reduce indenting levels
* Align args per style guide
* Improve (or remove) comments
* Pass around TemplateURL*s where convenient and safe instead of converting
to/from keywords. This generally simplifies things slightly and will be
useful for subsequent changes that need the TemplateURL*s in more places.
* Don't handle DCHECK failure
* Nuke long-outdated disabled KeywordProvider unittest
* Attempt (and probably fail) to put SearchProvider::CreateSearchSuggestion()
args in some sort of order
* Remove using directives where they don't save lines
* Follow style guide class declaration order
* Use OVERRIDE
* Make function declaration and definition order match
* Shorten/simplify code
* Put all three IsGoogleXXX() functions that take URLs in one group
* Eliminate unnecessary #includes
* Add GetDefaultSearchURLForSearchTerms() function to c/b/search_engines/util.h
since many disparate callers want to do that (and in a subsequent change I'll
want to slightly modify how that works)
* Fix presubmit warning about mismatched braces
* Remove unnecessary ResetDefaultTemplateURL() calls from ToolbarModel tests
BUG=249197
TEST=none
R=cpu@chromium.org, jered@chromium.org
Review URL: https://codereview.chromium.org/18119005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209228 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'native_client_sdk/src/tools')
0 files changed, 0 insertions, 0 deletions