diff options
| author | blundell@chromium.org <blundell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-13 13:44:23 +0000 |
|---|---|---|
| committer | blundell@chromium.org <blundell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-13 13:44:23 +0000 |
| commit | ba9722fca8f50bbdcab984fd8834f63d23f1229a (patch) | |
| tree | 4f1cd59bafce932f7e09b9789b8ac976d53ce4ff /native_client_sdk | |
| parent | c60d4241bfe99f40a3c94deaa188fb381dcba704 (diff) | |
| download | chromium_src-ba9722fca8f50bbdcab984fd8834f63d23f1229a.zip chromium_src-ba9722fca8f50bbdcab984fd8834f63d23f1229a.tar.gz chromium_src-ba9722fca8f50bbdcab984fd8834f63d23f1229a.tar.bz2 | |
Make mass-rename.py work on Unix.
Per 17.1.1.2 on http://docs.python.org/2/library/subprocess.html, passing
shell=True on Unix and having the command to run be specified as a sequence
means that "the first item specifies the command string, and any additional
items will be treated as additional arguments to the shell itself." This
results in incorrect behavior (and in particular, the popen.communicate() fails
with a return code of 1).
This CL switches to the recommended behavior of passing the command to run as a
string when specifying shell=True.
R=scottmg
Review URL: https://chromiumcodereview.appspot.com/16849002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206064 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'native_client_sdk')
0 files changed, 0 insertions, 0 deletions