Isolates generic DnsClient from AsyncHostResolver.

DnsClient provides a generic DNS client that allows fetching resource records. 
DnsClient is very lightweight and does not support aggregation, queuing or 
prioritization of requests. 

This is the first CL in a series to merge AsyncHostResolver into 
HostResolverImpl. 

Also introduces general-purpose BigEndianReader/Writer. 

BUG=90881
TEST=./net_unittests


Review URL: http://codereview.chromium.org/8762001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113282 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 9 insertions, 8 deletions

diff --git a/net/base/dns_util.cc b/net/base/dns_util.cc
index 93d789e..a49ada8 100644
--- a/net/base/dns_util.cc
+++ b/net/base/dns_util.cc
@@ -9,7 +9,7 @@
 namespace net {
 
 // Based on DJB's public domain code.
-bool DNSDomainFromDot(const std::string& dotted, std::string* out) {
+bool DNSDomainFromDot(const base::StringPiece& dotted, std::string* out) {
   const char* buf = dotted.data();
   unsigned n = dotted.size();
   char label[63];
@@ -56,7 +56,7 @@ bool DNSDomainFromDot(const std::string& dotted, std::string* out) {
   return true;
 }
 
-std::string DNSDomainToString(const std::string& domain) {
+std::string DNSDomainToString(const base::StringPiece& domain) {
   std::string ret;
 
   for (unsigned i = 0; i < domain.size() && domain[i]; i += domain[i] + 1) {
@@ -73,7 +73,7 @@ std::string DNSDomainToString(const std::string& domain) {
     if (static_cast<unsigned>(domain[i]) + i + 1 > domain.size())
       return "";
 
-    ret += domain.substr(i + 1, domain[i]);
+    domain.substr(i + 1, domain[i]).AppendToString(&ret);
   }
   return ret;
 }
@@ -92,12 +92,13 @@ bool IsSTD3ASCIIValidCharacter(char c) {
   return true;
 }
 
-std::string TrimEndingDot(const std::string& host) {
-  std::string host_trimmed = host;
+std::string TrimEndingDot(const base::StringPiece& host) {
+  base::StringPiece host_trimmed = host;
   size_t len = host_trimmed.length();
-  if (len > 1 && host_trimmed[len - 1] == '.')
-    host_trimmed.erase(len - 1);
-  return host_trimmed;
+  if (len > 1 && host_trimmed[len - 1] == '.') {
+    host_trimmed.remove_suffix(1);
+  }
+  return host_trimmed.as_string();
 }
 
 bool DnsResponseBuffer::U8(uint8* v) {