summaryrefslogtreecommitdiffstats
path: root/net/base/host_resolver_impl.cc
diff options
context:
space:
mode:
authorrsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-28 09:29:28 +0000
committerrsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-28 09:29:28 +0000
commita981330295415845ef13cd85afeff42032d782df (patch)
tree46ad72c4cabd094a5f4dea2faa1bde6fb7d3677f /net/base/host_resolver_impl.cc
parent20eef6d14fce11a57949d052db064e56242c4c82 (diff)
downloadchromium_src-a981330295415845ef13cd85afeff42032d782df.zip
chromium_src-a981330295415845ef13cd85afeff42032d782df.tar.gz
chromium_src-a981330295415845ef13cd85afeff42032d782df.tar.bz2
RefCounted types should not have public destructors, net/
BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10066045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134460 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/host_resolver_impl.cc')
-rw-r--r--net/base/host_resolver_impl.cc24
1 files changed, 24 insertions, 0 deletions
diff --git a/net/base/host_resolver_impl.cc b/net/base/host_resolver_impl.cc
index 0525459..541246f 100644
--- a/net/base/host_resolver_impl.cc
+++ b/net/base/host_resolver_impl.cc
@@ -175,6 +175,9 @@ class CallSystemHostResolverProc : public HostResolverProc {
addr_list,
os_error);
}
+
+ protected:
+ virtual ~CallSystemHostResolverProc() {}
};
// Extra parameters to attach to the NetLog when the resolve failed.
@@ -216,6 +219,9 @@ class ProcTaskFailedParams : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~ProcTaskFailedParams() {}
+
private:
const uint32 attempt_number_;
const int net_error_;
@@ -237,6 +243,9 @@ class DnsTaskFailedParams : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~DnsTaskFailedParams() {}
+
private:
const int net_error_;
const int dns_error_;
@@ -265,6 +274,9 @@ class RequestInfoParameters : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~RequestInfoParameters() {}
+
private:
const HostResolver::RequestInfo info_;
const NetLog::Source source_;
@@ -284,6 +296,9 @@ class JobCreationParameters : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~JobCreationParameters() {}
+
private:
const std::string host_;
const NetLog::Source source_;
@@ -303,6 +318,9 @@ class JobAttachParameters : public NetLog::EventParameters {
return dict;
}
+ protected:
+ virtual ~JobAttachParameters() {}
+
private:
const NetLog::Source source_;
const RequestPriority priority_;
@@ -326,6 +344,9 @@ class DnsConfigParameters : public NetLog::EventParameters {
return value;
}
+ protected:
+ virtual ~DnsConfigParameters() {}
+
private:
DnsConfig config_; // Does not include DnsHosts to save memory and work.
const size_t num_hosts_;
@@ -635,6 +656,9 @@ class HostResolverImpl::ProcTask
}
private:
+ friend class base::RefCountedThreadSafe<ProcTask>;
+ ~ProcTask() {}
+
void StartLookupAttempt() {
DCHECK(origin_loop_->BelongsToCurrentThread());
base::TimeTicks start_time = base::TimeTicks::Now();