diff options
author | mmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-30 01:32:30 +0000 |
---|---|---|
committer | mmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-30 01:32:30 +0000 |
commit | 62bde744e6697d644964f18fdfd051fdb6fbf0bd (patch) | |
tree | be2fe5ca4e2bfe7f61b1c47306ca75e739e09490 /net/base/net_log.h | |
parent | b520507ab4ae017818047d22609a4d2fb1cf0e44 (diff) | |
download | chromium_src-62bde744e6697d644964f18fdfd051fdb6fbf0bd.zip chromium_src-62bde744e6697d644964f18fdfd051fdb6fbf0bd.tar.gz chromium_src-62bde744e6697d644964f18fdfd051fdb6fbf0bd.tar.bz2 |
Disable ChromeNetLog when there are no observers.
Performance gains are probably neglible, though it does
prevent locking.
Review URL: https://codereview.chromium.org/12209100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191485 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/net_log.h')
-rw-r--r-- | net/base/net_log.h | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/net/base/net_log.h b/net/base/net_log.h index 0dd97ee..8ae33e9 100644 --- a/net/base/net_log.h +++ b/net/base/net_log.h @@ -60,6 +60,10 @@ class NET_EXPORT NetLog { }; // Specifies the granularity of events that should be emitted to the log. + // + // Since the LogLevel may be read and set on any thread without locking, it + // may be possible for an Observer to receive an event or parameters that + // normally wouldn't be logged at the currently active log level. enum LogLevel { // Log everything possible, even if it is slow and memory expensive. // Includes logging of transferred bytes. @@ -69,8 +73,12 @@ class NET_EXPORT NetLog { // parameters for bytes sent/received events. LOG_ALL_BUT_BYTES, - // Only log events which are cheap, and don't consume much memory. + // Only log events which are cheap, and don't consume much memory. This is + // the default value for observers. LOG_BASIC, + + // Don't log any events. + LOG_NONE, }; // A callback function that return a Value representation of the parameters |