diff options
| author | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-19 23:01:28 +0000 |
|---|---|---|
| committer | sky@google.com <sky@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-19 23:01:28 +0000 |
| commit | f785ad125747f9125c952c7e74f2154098ee15a9 (patch) | |
| tree | 69f59438f60dc382d7159d25e2cd34320b71c3c3 /net/base/net_util.cc | |
| parent | ec322ff6c39bf30e9b3c1eb878a95507029c6002 (diff) | |
| download | chromium_src-f785ad125747f9125c952c7e74f2154098ee15a9.zip chromium_src-f785ad125747f9125c952c7e74f2154098ee15a9.tar.gz chromium_src-f785ad125747f9125c952c7e74f2154098ee15a9.tar.bz2 | |
Fixes crash when showing modal dialog from context menu. With this
sequence ContainerWin remains on the stack while the modal dialog is
showing. Prior to this fix we would delete the ContainerWin, so that
when the modal dialog closed control would return to a deleted
object. The fix is to effectively delay deleting of the ConatinerWins
used by menus.
BUG=4580
TEST=This is the sequence that triggered the crash: open a folder on
the bookmark bar, right child on a child folder that has more than 15
descendant URLs, click open all, a dialog should appear asking if you
really want to open all, click cancel and make sure it doesn't crash.
This is a subtle change to bookmark menus though, would be good to
thoroughly exercise the menus in as many permutations as you can
think of.
Review URL: http://codereview.chromium.org/11289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5724 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base/net_util.cc')
0 files changed, 0 insertions, 0 deletions