diff options
| author | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-15 21:03:54 +0000 |
|---|---|---|
| committer | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-15 21:03:54 +0000 |
| commit | 3a3d4747769aec2954a2ca21de4812c5892994aa (patch) | |
| tree | db112f2c73cc39e9d6088059eae1fc9d35b74920 /net/base | |
| parent | 2235b22b88260fde392b753b5d7bb7904e5efbc6 (diff) | |
| download | chromium_src-3a3d4747769aec2954a2ca21de4812c5892994aa.zip chromium_src-3a3d4747769aec2954a2ca21de4812c5892994aa.tar.gz chromium_src-3a3d4747769aec2954a2ca21de4812c5892994aa.tar.bz2 | |
Move implementation from header to source.
This is an effort to speed up compile and link time, and also minimizing the
size of the intermediary .o files on disk. For example, just moving the
constructor/destructor from the classes in chrome/browser/pref_member.{cc,h}
netted a 368k drop in total .o file size. In aggregate, this shrinks
libbrowser.a by 10 megabytes, and a few odd megabytes on most other chrome .a files.
A lot of this was done before I started harvesting what the most included
symbols were across all of chrome's code. Most of them are in webkit, but
there's plenty in base/ that are used everywhere to keep me busy for several
patches to come.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3012001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52528 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/base')
| -rw-r--r-- | net/base/filter.cc | 3 | ||||
| -rw-r--r-- | net/base/filter.h | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/net/base/filter.cc b/net/base/filter.cc index 4a7b8a6..c72e00e 100644 --- a/net/base/filter.cc +++ b/net/base/filter.cc @@ -36,6 +36,9 @@ const char kTextHtml[] = "text/html"; } // namespace +FilterContext::~FilterContext() { +} + Filter* Filter::Factory(const std::vector<FilterType>& filter_types, const FilterContext& filter_context) { DCHECK_GT(filter_context.GetInputStreamBufferSize(), 0); diff --git a/net/base/filter.h b/net/base/filter.h index cf32d2f..acc0e7e 100644 --- a/net/base/filter.h +++ b/net/base/filter.h @@ -62,7 +62,7 @@ class FilterContext { SDCH_EXPERIMENT_HOLDBACK, }; - virtual ~FilterContext() {} + virtual ~FilterContext(); // What mime type was specified in the header for this data? // Only makes senses for some types of contexts, and returns false |