diff options
author | skyostil <skyostil@chromium.org> | 2015-06-11 04:43:45 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-06-11 11:44:22 +0000 |
commit | 4891b25ba40ddc3fb9c7c1f51de05f76ec86e9c5 (patch) | |
tree | d10caf7c5ba6146ad032183070d238fbff24e830 /net/cookies | |
parent | 8b0b7ad8063e289f1ddb7c3e1bed1965bd30024b (diff) | |
download | chromium_src-4891b25ba40ddc3fb9c7c1f51de05f76ec86e9c5.zip chromium_src-4891b25ba40ddc3fb9c7c1f51de05f76ec86e9c5.tar.gz chromium_src-4891b25ba40ddc3fb9c7c1f51de05f76ec86e9c5.tar.bz2 |
net: Remove use of MessageLoopProxy and deprecated MessageLoop APIs
This patch was mostly autogenerated with https://codereview.chromium.org/1010073002/.
BUG=465354
Review URL: https://codereview.chromium.org/1170183002
Cr-Commit-Position: refs/heads/master@{#333929}
Diffstat (limited to 'net/cookies')
-rw-r--r-- | net/cookies/cookie_monster.cc | 4 | ||||
-rw-r--r-- | net/cookies/cookie_monster_store_test.cc | 16 | ||||
-rw-r--r-- | net/cookies/cookie_monster_unittest.cc | 13 | ||||
-rw-r--r-- | net/cookies/cookie_store_test_callbacks.cc | 5 | ||||
-rw-r--r-- | net/cookies/cookie_store_test_helpers.cc | 17 | ||||
-rw-r--r-- | net/cookies/cookie_store_unittest.h | 7 |
6 files changed, 36 insertions, 26 deletions
diff --git a/net/cookies/cookie_monster.cc b/net/cookies/cookie_monster.cc index a83ec11..b474616 100644 --- a/net/cookies/cookie_monster.cc +++ b/net/cookies/cookie_monster.cc @@ -51,9 +51,9 @@ #include "base/basictypes.h" #include "base/bind.h" #include "base/callback.h" +#include "base/location.h" #include "base/logging.h" #include "base/memory/scoped_ptr.h" -#include "base/message_loop/message_loop.h" #include "base/metrics/field_trial.h" #include "base/metrics/histogram.h" #include "base/profiler/scoped_tracker.h" @@ -1362,7 +1362,7 @@ void CookieMonster::FlushStore(const base::Closure& callback) { if (initialized_ && store_.get()) store_->Flush(callback); else if (!callback.is_null()) - base::MessageLoop::current()->PostTask(FROM_HERE, callback); + base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, callback); } bool CookieMonster::SetCookieWithOptions(const GURL& url, diff --git a/net/cookies/cookie_monster_store_test.cc b/net/cookies/cookie_monster_store_test.cc index ede98ec..bf422ed 100644 --- a/net/cookies/cookie_monster_store_test.cc +++ b/net/cookies/cookie_monster_store_test.cc @@ -5,8 +5,10 @@ #include "net/cookies/cookie_monster_store_test.h" #include "base/bind.h" -#include "base/message_loop/message_loop.h" +#include "base/location.h" +#include "base/single_thread_task_runner.h" #include "base/strings/stringprintf.h" +#include "base/thread_task_runner_handle.h" #include "base/time/time.h" #include "net/cookies/cookie_constants.h" #include "net/cookies/cookie_util.h" @@ -40,7 +42,7 @@ void MockPersistentCookieStore::Load(const LoadedCallback& loaded_callback) { out_cookies = load_result_; loaded_ = true; } - base::MessageLoop::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(&LoadedCallbackTask::Run, new LoadedCallbackTask(loaded_callback, out_cookies))); @@ -52,7 +54,7 @@ void MockPersistentCookieStore::LoadCookiesForKey( if (!loaded_) { Load(loaded_callback); } else { - base::MessageLoop::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(&LoadedCallbackTask::Run, new LoadedCallbackTask(loaded_callback, @@ -76,7 +78,7 @@ void MockPersistentCookieStore::DeleteCookie(const CanonicalCookie& cookie) { void MockPersistentCookieStore::Flush(const base::Closure& callback) { if (!callback.is_null()) - base::MessageLoop::current()->PostTask(FROM_HERE, callback); + base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, callback); } void MockPersistentCookieStore::SetForceKeepSessionState() { @@ -144,7 +146,7 @@ void MockSimplePersistentCookieStore::Load( it != cookies_.end(); it++) out_cookies.push_back(new CanonicalCookie(it->second)); - base::MessageLoop::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(&LoadedCallbackTask::Run, new LoadedCallbackTask(loaded_callback, out_cookies))); @@ -157,7 +159,7 @@ void MockSimplePersistentCookieStore::LoadCookiesForKey( if (!loaded_) { Load(loaded_callback); } else { - base::MessageLoop::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(&LoadedCallbackTask::Run, new LoadedCallbackTask(loaded_callback, @@ -188,7 +190,7 @@ void MockSimplePersistentCookieStore::DeleteCookie( void MockSimplePersistentCookieStore::Flush(const base::Closure& callback) { if (!callback.is_null()) - base::MessageLoop::current()->PostTask(FROM_HERE, callback); + base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, callback); } void MockSimplePersistentCookieStore::SetForceKeepSessionState() { diff --git a/net/cookies/cookie_monster_unittest.cc b/net/cookies/cookie_monster_unittest.cc index 61dbd09..5452f19 100644 --- a/net/cookies/cookie_monster_unittest.cc +++ b/net/cookies/cookie_monster_unittest.cc @@ -10,17 +10,20 @@ #include "base/basictypes.h" #include "base/bind.h" +#include "base/location.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" #include "base/memory/scoped_vector.h" #include "base/message_loop/message_loop.h" #include "base/metrics/histogram.h" #include "base/metrics/histogram_samples.h" +#include "base/single_thread_task_runner.h" #include "base/strings/string_number_conversions.h" #include "base/strings/string_piece.h" #include "base/strings/string_split.h" #include "base/strings/string_tokenizer.h" #include "base/strings/stringprintf.h" +#include "base/thread_task_runner_handle.h" #include "base/threading/thread.h" #include "base/time/time.h" #include "net/cookies/canonical_cookie.h" @@ -54,7 +57,7 @@ class NewMockPersistentCookieStore MOCK_METHOD1(DeleteCookie, void(const CanonicalCookie& cc)); virtual void Flush(const base::Closure& callback) { if (!callback.is_null()) - base::MessageLoop::current()->PostTask(FROM_HERE, callback); + base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, callback); } MOCK_METHOD0(SetForceKeepSessionState, void()); @@ -637,8 +640,8 @@ struct CookiesInputInfo { }; ACTION(QuitCurrentMessageLoop) { - base::MessageLoop::current()->PostTask(FROM_HERE, - base::MessageLoop::QuitClosure()); + base::ThreadTaskRunnerHandle::Get()->PostTask( + FROM_HERE, base::MessageLoop::QuitClosure()); } // TODO(erikwright): When the synchronous helpers 'GetCookies' etc. are removed, @@ -2062,7 +2065,7 @@ class FlushablePersistentStore : public CookieMonster::PersistentCookieStore { void Load(const LoadedCallback& loaded_callback) override { std::vector<CanonicalCookie*> out_cookies; - base::MessageLoop::current()->PostTask( + base::ThreadTaskRunnerHandle::Get()->PostTask( FROM_HERE, base::Bind(&LoadedCallbackTask::Run, new LoadedCallbackTask(loaded_callback, out_cookies))); @@ -2445,7 +2448,7 @@ class MultiThreadedCookieMonsterTest : public CookieMonsterTest { protected: void RunOnOtherThread(const base::Closure& task) { other_thread_.Start(); - other_thread_.message_loop()->PostTask(FROM_HERE, task); + other_thread_.task_runner()->PostTask(FROM_HERE, task); RunFor(kTimeout); other_thread_.Stop(); } diff --git a/net/cookies/cookie_store_test_callbacks.cc b/net/cookies/cookie_store_test_callbacks.cc index 8ba1c94..afb05d1 100644 --- a/net/cookies/cookie_store_test_callbacks.cc +++ b/net/cookies/cookie_store_test_callbacks.cc @@ -4,7 +4,9 @@ #include "net/cookies/cookie_store_test_callbacks.h" +#include "base/location.h" #include "base/message_loop/message_loop.h" +#include "base/single_thread_task_runner.h" #include "base/threading/thread.h" #include "testing/gtest/include/gtest/gtest.h" @@ -36,7 +38,8 @@ void CookieCallback::CallbackEpilogue() { did_run_ = true; EXPECT_EQ(expected_loop, base::MessageLoop::current()); - loop_to_quit_->PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); + loop_to_quit_->task_runner()->PostTask(FROM_HERE, + base::MessageLoop::QuitClosure()); } StringResultCookieCallback::StringResultCookieCallback() {} diff --git a/net/cookies/cookie_store_test_helpers.cc b/net/cookies/cookie_store_test_helpers.cc index bcf8c89..49f9d9a 100644 --- a/net/cookies/cookie_store_test_helpers.cc +++ b/net/cookies/cookie_store_test_helpers.cc @@ -5,7 +5,9 @@ #include "net/cookies/cookie_store_test_helpers.h" #include "base/bind.h" -#include "base/message_loop/message_loop.h" +#include "base/location.h" +#include "base/single_thread_task_runner.h" +#include "base/thread_task_runner_handle.h" namespace net { @@ -42,11 +44,9 @@ void DelayedCookieMonster::SetCookieWithOptionsAsync( base::Bind(&DelayedCookieMonster::SetCookiesInternalCallback, base::Unretained(this))); DCHECK_EQ(did_run_, true); - base::MessageLoop::current()->PostDelayedTask( - FROM_HERE, - base::Bind(&DelayedCookieMonster::InvokeSetCookiesCallback, - base::Unretained(this), - callback), + base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( + FROM_HERE, base::Bind(&DelayedCookieMonster::InvokeSetCookiesCallback, + base::Unretained(this), callback), base::TimeDelta::FromMilliseconds(kDelayedTime)); } @@ -60,11 +60,10 @@ void DelayedCookieMonster::GetCookiesWithOptionsAsync( base::Bind(&DelayedCookieMonster::GetCookiesWithOptionsInternalCallback, base::Unretained(this))); DCHECK_EQ(did_run_, true); - base::MessageLoop::current()->PostDelayedTask( + base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( FROM_HERE, base::Bind(&DelayedCookieMonster::InvokeGetCookieStringCallback, - base::Unretained(this), - callback), + base::Unretained(this), callback), base::TimeDelta::FromMilliseconds(kDelayedTime)); } diff --git a/net/cookies/cookie_store_unittest.h b/net/cookies/cookie_store_unittest.h index fa429fd..763b6bf 100644 --- a/net/cookies/cookie_store_unittest.h +++ b/net/cookies/cookie_store_unittest.h @@ -6,8 +6,11 @@ #define NET_COOKIES_COOKIE_STORE_UNITTEST_H_ #include "base/bind.h" +#include "base/location.h" #include "base/message_loop/message_loop.h" +#include "base/single_thread_task_runner.h" #include "base/strings/string_tokenizer.h" +#include "base/thread_task_runner_handle.h" #include "base/threading/thread.h" #include "net/cookies/cookie_monster.h" #include "net/cookies/cookie_store.h" @@ -208,7 +211,7 @@ class CookieStoreTest : public testing::Test { void RunFor(int ms) { // Runs the test thread message loop for up to |ms| milliseconds. - base::MessageLoop::current()->PostDelayedTask( + base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( FROM_HERE, base::Bind(&base::MessageLoop::Quit, weak_factory_->GetWeakPtr()), base::TimeDelta::FromMilliseconds(ms)); @@ -1089,7 +1092,7 @@ class MultiThreadedCookieStoreTest : protected: void RunOnOtherThread(const base::Closure& task) { other_thread_.Start(); - other_thread_.message_loop()->PostTask(FROM_HERE, task); + other_thread_.task_runner()->PostTask(FROM_HERE, task); CookieStoreTest<CookieStoreTestTraits>::RunFor(kTimeout); other_thread_.Stop(); } |