summaryrefslogtreecommitdiffstats
path: root/net/disk_cache
diff options
context:
space:
mode:
authortfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-08-19 19:14:00 +0000
committertfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-08-19 19:14:00 +0000
commit1e43b6816aee7f20d12ec61b69bc05fe1dc0d449 (patch)
tree798aff06960e2f6502b8295de360c7e645d10850 /net/disk_cache
parentda35960ef9fc0bfb80a6ef6306287e6241770239 (diff)
downloadchromium_src-1e43b6816aee7f20d12ec61b69bc05fe1dc0d449.zip
chromium_src-1e43b6816aee7f20d12ec61b69bc05fe1dc0d449.tar.gz
chromium_src-1e43b6816aee7f20d12ec61b69bc05fe1dc0d449.tar.bz2
net: Fix more clang warnings about missing virtual and OVERRIDE annotations.
BUG=115047 R=willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152296 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/disk_cache')
-rw-r--r--net/disk_cache/entry_impl.cc4
-rw-r--r--net/disk_cache/file_posix.cc6
-rw-r--r--net/disk_cache/sparse_control.cc4
3 files changed, 7 insertions, 7 deletions
diff --git a/net/disk_cache/entry_impl.cc b/net/disk_cache/entry_impl.cc
index 6155aa1..e4eb75a 100644
--- a/net/disk_cache/entry_impl.cc
+++ b/net/disk_cache/entry_impl.cc
@@ -40,9 +40,9 @@ class SyncCallback: public disk_cache::FileIOCallback {
entry->AddRef();
entry->IncrementIoCount();
}
- ~SyncCallback() {}
+ virtual ~SyncCallback() {}
- virtual void OnFileIOComplete(int bytes_copied);
+ virtual void OnFileIOComplete(int bytes_copied) OVERRIDE;
void Discard();
private:
diff --git a/net/disk_cache/file_posix.cc b/net/disk_cache/file_posix.cc
index e03d955..c334f28 100644
--- a/net/disk_cache/file_posix.cc
+++ b/net/disk_cache/file_posix.cc
@@ -49,7 +49,7 @@ class FileBackgroundIO : public disk_cache::BackgroundIO {
void Write();
private:
- ~FileBackgroundIO() {}
+ virtual ~FileBackgroundIO() {}
disk_cache::FileIOCallback* callback_;
@@ -66,7 +66,7 @@ class FileBackgroundIO : public disk_cache::BackgroundIO {
class FileInFlightIO : public disk_cache::InFlightIO {
public:
FileInFlightIO() {}
- ~FileInFlightIO() {}
+ virtual ~FileInFlightIO() {}
// These methods start an asynchronous operation. The arguments have the same
// semantics of the File asynchronous operations, with the exception that the
@@ -82,7 +82,7 @@ class FileInFlightIO : public disk_cache::InFlightIO {
// queued (because we are inside WaitForPendingIO), and false if said task is
// the one performing the call.
virtual void OnOperationComplete(disk_cache::BackgroundIO* operation,
- bool cancel);
+ bool cancel) OVERRIDE;
private:
DISALLOW_COPY_AND_ASSIGN(FileInFlightIO);
diff --git a/net/disk_cache/sparse_control.cc b/net/disk_cache/sparse_control.cc
index 136463e..52fd328 100644
--- a/net/disk_cache/sparse_control.cc
+++ b/net/disk_cache/sparse_control.cc
@@ -56,7 +56,7 @@ class ChildrenDeleter
ChildrenDeleter(disk_cache::BackendImpl* backend, const std::string& name)
: backend_(backend->GetWeakPtr()), name_(name), signature_(0) {}
- virtual void OnFileIOComplete(int bytes_copied);
+ virtual void OnFileIOComplete(int bytes_copied) OVERRIDE;
// Two ways of deleting the children: if we have the children map, use Start()
// directly, otherwise pass the data address to ReadData().
@@ -65,7 +65,7 @@ class ChildrenDeleter
private:
friend class base::RefCounted<ChildrenDeleter>;
- ~ChildrenDeleter() {}
+ virtual ~ChildrenDeleter() {}
void DeleteChildren();