diff options
| author | pasko@chromium.org <pasko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-02 23:59:04 +0000 |
|---|---|---|
| committer | pasko@chromium.org <pasko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-02 23:59:04 +0000 |
| commit | a5b13adca0eb7e3031e0ac21a5f66fb3dce9675b (patch) | |
| tree | 3845305ced2b3b510a3aae7db39303823d4f954d /net/disk_cache | |
| parent | 9a0f430111db397dc5119f697c95bc20881e3e2e (diff) | |
| download | chromium_src-a5b13adca0eb7e3031e0ac21a5f66fb3dce9675b.zip chromium_src-a5b13adca0eb7e3031e0ac21a5f66fb3dce9675b.tar.gz chromium_src-a5b13adca0eb7e3031e0ac21a5f66fb3dce9675b.tar.bz2 | |
simple cache: bump version
If we receive a report with cache read error, we are not 100% sure whether it
happened because the newest binary has a bug or because the old one wrote a file
incorrectly. To be absolutely sure that the bug needs attention we should reset
the cache for the new binaries.
We seem to correctly doom the entries with read error, even in CRC check failure
case (kudos to gavinp@, you rock), but the error would be displayed to the user
once anyway.
Flushing cache has undesirable effects like:
1. having to re-login to some websites
2. performance comparisons with the control group are no longer valid
There is one alternative: make a retry, but that would make the code more
complex by adding another state, would require longer review, would have to be
undone later at the moment when we are almost sure there are no old entries in
the wild. Mission impossible.
Given how much we want to be stable, we absolutely should reset the cache.
BUG=239223
Review URL: https://chromiumcodereview.appspot.com/16299004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203643 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/disk_cache')
| -rw-r--r-- | net/disk_cache/simple/simple_entry_format.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/disk_cache/simple/simple_entry_format.h b/net/disk_cache/simple/simple_entry_format.h index d309f2c..b25bc7f 100644 --- a/net/disk_cache/simple/simple_entry_format.h +++ b/net/disk_cache/simple/simple_entry_format.h @@ -27,7 +27,7 @@ const uint64 kSimpleFinalMagicNumber = GG_UINT64_C(0xf4fa6f45970d41d8); // - the key. // - the data. // - at the end, a SimpleFileEOF record. -const uint32 kSimpleVersion = 2; +const uint32 kSimpleVersion = 3; static const int kSimpleEntryFileCount = 3; |