RefCounted types should not have public destructors, net/

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10066045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134460 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 55 insertions, 12 deletions

diff --git a/net/disk_cache/net_log_parameters.cc b/net/disk_cache/net_log_parameters.cc
index 76d79d7..3a309f9 100644
--- a/net/disk_cache/net_log_parameters.cc
+++ b/net/disk_cache/net_log_parameters.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -12,8 +12,10 @@
 namespace disk_cache {
 
 EntryCreationParameters::EntryCreationParameters(
-    const std::string& key, bool created)
-    : key_(key), created_(created) {
+    const std::string& key,
+    bool created)
+    : key_(key),
+      created_(created) {
 }
 
 Value* EntryCreationParameters::ToValue() const {
@@ -23,9 +25,17 @@ Value* EntryCreationParameters::ToValue() const {
   return dict;
 }
 
+EntryCreationParameters::~EntryCreationParameters() {}
+
 ReadWriteDataParameters::ReadWriteDataParameters(
-    int index, int offset, int buf_len, bool truncate)
-    : index_(index), offset_(offset), buf_len_(buf_len), truncate_(truncate) {
+    int index,
+    int offset,
+    int buf_len,
+    bool truncate)
+    : index_(index),
+      offset_(offset),
+      buf_len_(buf_len),
+      truncate_(truncate) {
 }
 
 Value* ReadWriteDataParameters::ToValue() const {
@@ -38,6 +48,7 @@ Value* ReadWriteDataParameters::ToValue() const {
   return dict;
 }
 
+ReadWriteDataParameters::~ReadWriteDataParameters() {}
 
 // NetLog parameters logged when non-sparse reads and writes complete.
 ReadWriteCompleteParameters::ReadWriteCompleteParameters(int bytes_copied)
@@ -55,9 +66,13 @@ Value* ReadWriteCompleteParameters::ToValue() const {
   return dict;
 }
 
+ReadWriteCompleteParameters::~ReadWriteCompleteParameters() {}
+
 SparseOperationParameters::SparseOperationParameters(
-    int64 offset, int buff_len)
-    : offset_(offset), buff_len_(buff_len) {
+    int64 offset,
+    int buff_len)
+    : offset_(offset),
+      buff_len_(buff_len) {
 }
 
 Value* SparseOperationParameters::ToValue() const {
@@ -69,9 +84,13 @@ Value* SparseOperationParameters::ToValue() const {
   return dict;
 }
 
+SparseOperationParameters::~SparseOperationParameters() {}
+
 SparseReadWriteParameters::SparseReadWriteParameters(
-    const net::NetLog::Source& source, int child_len)
-    : source_(source), child_len_(child_len) {
+    const net::NetLog::Source& source,
+    int child_len)
+    : source_(source),
+      child_len_(child_len) {
 }
 
 Value* SparseReadWriteParameters::ToValue() const {
@@ -81,9 +100,13 @@ Value* SparseReadWriteParameters::ToValue() const {
   return dict;
 }
 
+SparseReadWriteParameters::~SparseReadWriteParameters() {}
+
 GetAvailableRangeResultParameters::GetAvailableRangeResultParameters(
-    int64 start, int result)
-    : start_(start), result_(result) {
+    int64 start,
+    int result)
+    : start_(start),
+      result_(result) {
 }
 
 Value* GetAvailableRangeResultParameters::ToValue() const {
@@ -97,4 +120,6 @@ Value* GetAvailableRangeResultParameters::ToValue() const {
   return dict;
 }
 
+GetAvailableRangeResultParameters::~GetAvailableRangeResultParameters() {}
+
 }  // namespace disk_cache
diff --git a/net/disk_cache/net_log_parameters.h b/net/disk_cache/net_log_parameters.h
index d0b0c29..4e6b8fe 100644
--- a/net/disk_cache/net_log_parameters.h
+++ b/net/disk_cache/net_log_parameters.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -21,6 +21,9 @@ class EntryCreationParameters : public net::NetLog::EventParameters {
   EntryCreationParameters(const std::string& key, bool created);
   virtual base::Value* ToValue() const OVERRIDE;
 
+ protected:
+  virtual ~EntryCreationParameters();
+
  private:
   const std::string key_;
   const bool created_;
@@ -35,6 +38,9 @@ class ReadWriteDataParameters : public net::NetLog::EventParameters {
   ReadWriteDataParameters(int index, int offset, int buf_len, bool truncate);
   virtual base::Value* ToValue() const OVERRIDE;
 
+ protected:
+  virtual ~ReadWriteDataParameters();
+
  private:
   const int index_;
   const int offset_;
@@ -53,6 +59,9 @@ class ReadWriteCompleteParameters : public net::NetLog::EventParameters {
   explicit ReadWriteCompleteParameters(int bytes_copied);
   virtual base::Value* ToValue() const OVERRIDE;
 
+ protected:
+  virtual ~ReadWriteCompleteParameters();
+
  private:
   const int bytes_copied_;
 
@@ -65,6 +74,9 @@ class SparseOperationParameters : public net::NetLog::EventParameters {
   SparseOperationParameters(int64 offset, int buff_len);
   virtual base::Value* ToValue() const OVERRIDE;
 
+ protected:
+  virtual ~SparseOperationParameters();
+
  private:
   const int64 offset_;
   const int buff_len_;
@@ -77,6 +89,9 @@ class SparseReadWriteParameters : public net::NetLog::EventParameters {
   SparseReadWriteParameters(const net::NetLog::Source& source, int child_len);
   virtual base::Value* ToValue() const OVERRIDE;
 
+ protected:
+  virtual ~SparseReadWriteParameters();
+
  private:
   const net::NetLog::Source source_;
   const int child_len_;
@@ -89,6 +104,9 @@ class GetAvailableRangeResultParameters : public net::NetLog::EventParameters {
   GetAvailableRangeResultParameters(int64 start, int result);
   virtual base::Value* ToValue() const OVERRIDE;
 
+ protected:
+  virtual ~GetAvailableRangeResultParameters();
+
  private:
   const int64 start_;
   const int result_;