diff options
| author | Brett Wilson <brettw@chromium.org> | 2015-07-07 16:38:09 -0700 |
|---|---|---|
| committer | Brett Wilson <brettw@chromium.org> | 2015-07-07 23:39:16 +0000 |
| commit | e3c4d1a1228e00b190ad743a83f88a2266f45238 (patch) | |
| tree | 3923b42b43c9b7a8a689d0468688b30bf9ea8f83 /net/disk_cache | |
| parent | 1c33a26e56880fbf058fd796aa004e097e07b691 (diff) | |
| download | chromium_src-e3c4d1a1228e00b190ad743a83f88a2266f45238.zip chromium_src-e3c4d1a1228e00b190ad743a83f88a2266f45238.tar.gz chromium_src-e3c4d1a1228e00b190ad743a83f88a2266f45238.tar.bz2 | |
Move WriteInto to base namespace.
Update all callers.
De-inlines the template. For some reason touching the namespaces started givin errors about DCHECK not being defined. Indeed, this header does not include logging.h. Rather than include logging in this very common header, it seems preferable to move the implementation to the .cc file.
This removes support for the wstring variant and updates the callers that used it.
R=ben@chromium.org, ben
TBR=jschuh (sandbox_win.cc)
NOPRESUBMIT=true
(this patch touches code using legacy wstrings)
Review URL: https://codereview.chromium.org/1223983002.
Cr-Commit-Position: refs/heads/master@{#337703}
Diffstat (limited to 'net/disk_cache')
| -rw-r--r-- | net/disk_cache/blockfile/entry_impl.cc | 2 | ||||
| -rw-r--r-- | net/disk_cache/blockfile/entry_impl_v3.cc | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/net/disk_cache/blockfile/entry_impl.cc b/net/disk_cache/blockfile/entry_impl.cc index ed975e1..c26026e 100644 --- a/net/disk_cache/blockfile/entry_impl.cc +++ b/net/disk_cache/blockfile/entry_impl.cc @@ -785,7 +785,7 @@ std::string EntryImpl::GetKey() const { if (!offset && key_file->GetLength() != static_cast<size_t>(key_len)) return std::string(); - if (!key_file->Read(WriteInto(&key_, key_len), key_len, offset)) + if (!key_file->Read(base::WriteInto(&key_, key_len), key_len, offset)) key_.clear(); return key_; } diff --git a/net/disk_cache/blockfile/entry_impl_v3.cc b/net/disk_cache/blockfile/entry_impl_v3.cc index 01ac276..7371936 100644 --- a/net/disk_cache/blockfile/entry_impl_v3.cc +++ b/net/disk_cache/blockfile/entry_impl_v3.cc @@ -498,7 +498,7 @@ std::string EntryImplV3::GetKey() const { if (!offset && key_file->GetLength() != static_cast<size_t>(key_len)) return std::string(); - if (!key_file->Read(WriteInto(&key_, key_len), key_len, offset)) + if (!key_file->Read(base::WriteInto(&key_, key_len), key_len, offset)) key_.clear(); return key_; } |