summaryrefslogtreecommitdiffstats
path: root/net/filter
diff options
context:
space:
mode:
authorrdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-20 04:30:06 +0000
committerrdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-20 04:30:06 +0000
commitdfc75134d04a7a0552de853dc84368a70208dd85 (patch)
tree776fd8419fbdc3f002bf99164cea0fbf2fc00bdc /net/filter
parente7dcbedbc317f86654cd8919278a1cfcc0909676 (diff)
downloadchromium_src-dfc75134d04a7a0552de853dc84368a70208dd85.zip
chromium_src-dfc75134d04a7a0552de853dc84368a70208dd85.tar.gz
chromium_src-dfc75134d04a7a0552de853dc84368a70208dd85.tar.bz2
Do a quick tweak downwards to SDCH memory limits (esp for mobile).
This will allow experimentation to occur in M37 without concern about blowing out memory. A more thorough memory limit re-evaluation is expected in M38. BUG=374917 R=cbentzel@chromium.org Review URL: https://codereview.chromium.org/342523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278590 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/filter')
-rw-r--r--net/filter/sdch_filter_unittest.cc25
1 files changed, 19 insertions, 6 deletions
diff --git a/net/filter/sdch_filter_unittest.cc b/net/filter/sdch_filter_unittest.cc
index 16012c3..28da615 100644
--- a/net/filter/sdch_filter_unittest.cc
+++ b/net/filter/sdch_filter_unittest.cc
@@ -394,12 +394,15 @@ TEST_F(SdchFilterTest, DictionaryAddOnce) {
const std::string kSampleDomain2 = "sdchtest2.com";
- // Construct a second SDCH dictionary from a VCDIFF dictionary.
- std::string dictionary2(NewSdchDictionary(kSampleDomain2));
-
- std::string url_string2 = "http://" + kSampleDomain2;
- GURL url2(url_string2);
- EXPECT_TRUE(sdch_manager_->AddSdchDictionary(dictionary2, url2));
+ // Don't test adding a second dictionary if our limits are tight.
+ if (SdchManager::kMaxDictionaryCount > 1) {
+ // Construct a second SDCH dictionary from a VCDIFF dictionary.
+ std::string dictionary2(NewSdchDictionary(kSampleDomain2));
+
+ std::string url_string2 = "http://" + kSampleDomain2;
+ GURL url2(url_string2);
+ EXPECT_TRUE(sdch_manager_->AddSdchDictionary(dictionary2, url2));
+ }
}
TEST_F(SdchFilterTest, BasicDictionary) {
@@ -634,6 +637,11 @@ TEST_F(SdchFilterTest, CrossDomainDictionaryUse) {
}
TEST_F(SdchFilterTest, DictionaryPathValidation) {
+ // Can't test path distinction between dictionaries if we aren't allowed
+ // more than one dictionary.
+ if (SdchManager::kMaxDictionaryCount <= 1)
+ return;
+
// Construct a valid SDCH dictionary from a VCDIFF dictionary.
const std::string kSampleDomain = "sdchtest.com";
std::string dictionary(NewSdchDictionary(kSampleDomain));
@@ -683,6 +691,11 @@ TEST_F(SdchFilterTest, DictionaryPathValidation) {
}
TEST_F(SdchFilterTest, DictionaryPortValidation) {
+ // Can't test port distinction between dictionaries if we aren't allowed
+ // more than one dictionary.
+ if (SdchManager::kMaxDictionaryCount <= 1)
+ return;
+
// Construct a valid SDCH dictionary from a VCDIFF dictionary.
const std::string kSampleDomain = "sdchtest.com";
std::string dictionary(NewSdchDictionary(kSampleDomain));