diff options
| author | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-21 03:46:06 +0000 |
|---|---|---|
| committer | ericroman@google.com <ericroman@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-21 03:46:06 +0000 |
| commit | 89ceba9a484f853964e5504f14927a8cf7e72449 (patch) | |
| tree | 5db8fb2d7cebebc53b107db44f521f078b66cf62 /net/http/http_response_info.h | |
| parent | d0ee935a4bdb1d111a4584ec4c0a03287bc43cd4 (diff) | |
| download | chromium_src-89ceba9a484f853964e5504f14927a8cf7e72449.zip chromium_src-89ceba9a484f853964e5504f14927a8cf7e72449.tar.gz chromium_src-89ceba9a484f853964e5504f14927a8cf7e72449.tar.bz2 | |
Fully reset HttpNetworkTransaction::response_ when restarting the transaction. The reset is done using the default constructor.
This is less fragile than resetting each member manually, and in fact not all members were being reset (for example, vary_data and ssl_info).
In the case of vary_data this could cause a subtle glitch, since calling HttpVaryData::Init() twice on the same object doesn't fully re-initialize.
The changes outside of http_network_transaction.cc are just a safety net -- it seemed reasonable to make HttpVaryData::Init() support the multiple-init model.
Review URL: http://codereview.chromium.org/50031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12243 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http/http_response_info.h')
| -rw-r--r-- | net/http/http_response_info.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/http/http_response_info.h b/net/http/http_response_info.h index caa49df..d2803d1 100644 --- a/net/http/http_response_info.h +++ b/net/http/http_response_info.h @@ -19,8 +19,9 @@ class HttpResponseInfo { public: HttpResponseInfo(); ~HttpResponseInfo(); + // Default copy-constructor and assignment operator are OK! - // The following is only defined if the request_time memmber is set. + // The following is only defined if the request_time member is set. // If this response was resurrected from cache, then this bool is set, and // request_time may corresponds to a time "far" in the past. Note that // stale content (perhaps un-cacheable) may be fetched from cache subject to |