summaryrefslogtreecommitdiffstats
path: root/net/http/http_server_properties.cc
diff options
context:
space:
mode:
authormaniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-07-08 16:27:13 +0000
committermaniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-07-08 16:27:13 +0000
commitdb248c54114004e339c9e1b42d2f2486addd19fc (patch)
treea5465241988699b1ae3ab68132e8bbb9737b592c /net/http/http_server_properties.cc
parentec0e1e5a692388443804e6cce23a01d6b02e447e (diff)
downloadchromium_src-db248c54114004e339c9e1b42d2f2486addd19fc.zip
chromium_src-db248c54114004e339c9e1b42d2f2486addd19fc.tar.gz
chromium_src-db248c54114004e339c9e1b42d2f2486addd19fc.tar.bz2
Revert of Fix Windows logoff race. (https://codereview.chromium.org/349263004/)
Reason for revert: Suspected as cause of browser_tests failures on Mac10.7 Tests: http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/28572 ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #1): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [10963:519:0708/084058:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (780 ms) ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #2): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [12926:519:0708/084834:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (639 ms) ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #3): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [12935:519:0708/084836:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (551 ms) ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #4): [ RUN ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession [12937:519:0708/084837:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession() ../../chrome/browser/profiles/profile_browsertest.cc:365: Failure Value of: "SessionEnded" Expected: GetExitTypePreferenceFromDisk(profile) Which is: "Crashed" [ FAILED ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam = and GetParam() = (560 ms) Original issue's description: > Fix Windows logoff race by posting a sentinel task to each taskrunner used to save state, and blocking on the completion of all sentinels. > De-flake and re-enable ProfileBrowserTests, by not running the tasks queued to initialize Bookmarks. This caused test failures when the delayed initialization managed to run. > This depends on https://codereview.chromium.org/370323002/, which fixes a BookmarkStorage lifetime issue, and https://codereview.chromium.org/375683002/ which annotates a remaining leak. > > TBR=sky@chromium.org, brettw@chromium.org > > R=erikwright@chromium.org, gab=chromium.org, brettw@chromium.org > BUG=386126, 141141, 141517, 142787, 140882, 165760, 163713, 391508 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281746 TBR=siggi BUG=392186 NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/378863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281766 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http/http_server_properties.cc')
0 files changed, 0 insertions, 0 deletions