diff options
| author | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-02 15:46:11 +0000 |
|---|---|---|
| committer | mbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-02 15:46:11 +0000 |
| commit | 5d0429b18ea353cbfc8417fa57bf1bf131e4edaa (patch) | |
| tree | aecd7019abd0675c23669b132aa5da45e85452ba /net/http | |
| parent | d7883d0f35538d7f26031b069f941de51ce6c5d0 (diff) | |
| download | chromium_src-5d0429b18ea353cbfc8417fa57bf1bf131e4edaa.zip chromium_src-5d0429b18ea353cbfc8417fa57bf1bf131e4edaa.tar.gz chromium_src-5d0429b18ea353cbfc8417fa57bf1bf131e4edaa.tar.bz2 | |
With SPDY, when a proxy is set via automatic settings, we had a crash.
This turned out to be due to the HttpNetworkTransaction leaving the
response_ in tact, and accidentally tripping a condition check in the
SPDY code.
Fix is to properly clear out the response after the tunnel is established.
BUG=40159
TEST=none
Review URL: http://codereview.chromium.org/1572015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43479 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/http')
| -rw-r--r-- | net/http/http_network_transaction.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc index f3f4a7d..467f63c 100644 --- a/net/http/http_network_transaction.cc +++ b/net/http/http_network_transaction.cc @@ -1056,6 +1056,8 @@ int HttpNetworkTransaction::DoReadHeadersComplete(int result) { http_stream_.reset(new HttpBasicStream(connection_.get(), net_log_)); headers_valid_ = false; establishing_tunnel_ = false; + // TODO(mbelshe): We should put in a test case to trip this code path. + response_ = HttpResponseInfo(); return OK; // We aren't able to CONNECT to the remote host through the proxy. We |