diff options
| author | tyoshino@chromium.org <tyoshino@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-11 07:41:47 +0000 |
|---|---|---|
| committer | tyoshino@chromium.org <tyoshino@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-11 07:41:47 +0000 |
| commit | 41bd637464b116fe9adc7670e533947a7be3d059 (patch) | |
| tree | 0376875f0c8e33117bfcdc8c0642dc32f8e7268e /net/net.gyp | |
| parent | fad0389df8823e32bea1918228bbb663146bfa61 (diff) | |
| download | chromium_src-41bd637464b116fe9adc7670e533947a7be3d059.zip chromium_src-41bd637464b116fe9adc7670e533947a7be3d059.tar.gz chromium_src-41bd637464b116fe9adc7670e533947a7be3d059.tar.bz2 | |
Revert 192975 "[SPDY] Refactor SpdySession's write queue"
Looks like this caused use after free on Chromium OS (amd64) ASAN bot.
BUG=230259
> [SPDY] Refactor SpdySession's write queue
>
> This is in preparation for replacing the various IOBuffers used for reads/writes
> with a single SpdyBuffer class.
>
> Replace the priority queue of SpdyIOBufferProducers with a SpdyWriteQueue object,
> which is an an array of FIFO queues binned by priority.
> The priority queue was looking only at priority and so was not guaranteeing
> FIFO behavior among producers with the same priority.
>
> Remove the frame queue in SpdyStream and instead have it use the session's
> write queue directly.
>
> Remove unused fields from SpdyIOBuffer and clean it up.
>
> Propagate and handle errors from SpdyCredentialBuilder::Build.
>
> Rename SpdyIOBufferProducer to SpdyFrameProducer, have it return a SpdyFrame,
> clean up its interface, and move the stream-activating logic out of it.
>
> Replace uses of std::list with std::deque.
>
> Steamline logic in SpdySession that deals with the write queue.
>
> Convert some raw pointers to scoped_ptr<>.
>
> BUG=176582
>
> Review URL: https://codereview.chromium.org/13009012
TBR=akalin@chromium.org
Review URL: https://codereview.chromium.org/13880004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193597 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/net.gyp')
| -rw-r--r-- | net/net.gyp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/net/net.gyp b/net/net.gyp index 2bac047..9409258 100644 --- a/net/net.gyp +++ b/net/net.gyp @@ -858,8 +858,6 @@ 'spdy/spdy_credential_state.h', 'spdy/spdy_frame_builder.cc', 'spdy/spdy_frame_builder.h', - 'spdy/spdy_frame_producer.cc', - 'spdy/spdy_frame_producer.h', 'spdy/spdy_frame_reader.cc', 'spdy/spdy_frame_reader.h', 'spdy/spdy_framer.cc', @@ -885,8 +883,6 @@ 'spdy/spdy_stream.h', 'spdy/spdy_websocket_stream.cc', 'spdy/spdy_websocket_stream.h', - 'spdy/spdy_write_queue.cc', - 'spdy/spdy_write_queue.h', 'ssl/client_cert_store.h', 'ssl/client_cert_store_impl.h', 'ssl/client_cert_store_impl_mac.cc', @@ -1698,7 +1694,6 @@ 'spdy/spdy_websocket_test_util_spdy2.h', 'spdy/spdy_websocket_test_util_spdy3.cc', 'spdy/spdy_websocket_test_util_spdy3.h', - 'spdy/spdy_write_queue_unittest.cc', 'ssl/client_cert_store_impl_unittest.cc', 'ssl/default_server_bound_cert_store_unittest.cc', 'ssl/openssl_client_key_store_unittest.cc', |