summaryrefslogtreecommitdiffstats
path: root/net/proxy/network_delegate_error_observer_unittest.cc
diff options
context:
space:
mode:
authorbattre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-14 19:26:10 +0000
committerbattre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-07-14 19:26:10 +0000
commit5796dc94436c7d92b0b913aeb091ff6ea98ee575 (patch)
tree139f193789e8b2f412eaa4574b0af916fb7e896d /net/proxy/network_delegate_error_observer_unittest.cc
parentf667e2ee48c8347341b5dc18a409ee7f564cb266 (diff)
downloadchromium_src-5796dc94436c7d92b0b913aeb091ff6ea98ee575.zip
chromium_src-5796dc94436c7d92b0b913aeb091ff6ea98ee575.tar.gz
chromium_src-5796dc94436c7d92b0b913aeb091ff6ea98ee575.tar.bz2
Replace onRequestSent with onSendHeaders in webrequest API
This CL replaces the onRequestSent signal of the webrequest API with a new onSendHeader signal. The sequence is now: onBeforeRequest -> onBeforeSendHeaders -> onSendHeaders. This change allows us to completely remove the webrequest API from the network transaction layer and stay in the URL request layer. That solve the problem that the network layer may convert one URLRequest to multiple HTTP requests which should be transparent to the webrequest API. It also solves the problem that requests answered from the cache did not trigger an onRequestSent event. Given the choice of removing onRequestSent completely and replacing it with onSendHeaders, I chose the latter so that extensions can see the headers sent to the network after other extensions had a chance to modify them. BUG=no TEST=no Review URL: http://codereview.chromium.org/7353021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92584 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy/network_delegate_error_observer_unittest.cc')
-rw-r--r--net/proxy/network_delegate_error_observer_unittest.cc3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/proxy/network_delegate_error_observer_unittest.cc b/net/proxy/network_delegate_error_observer_unittest.cc
index ca81258..5979909 100644
--- a/net/proxy/network_delegate_error_observer_unittest.cc
+++ b/net/proxy/network_delegate_error_observer_unittest.cc
@@ -35,8 +35,7 @@ class TestNetworkDelegate : public net::NetworkDelegate {
HttpRequestHeaders* headers) {
return net::OK;
}
- virtual void OnRequestSent(uint64 request_id,
- const HostPortPair& socket_address,
+ virtual void OnSendHeaders(URLRequest* request,
const HttpRequestHeaders& headers) {}
virtual void OnBeforeRedirect(URLRequest* request,
const GURL& new_location) {}