diff options
| author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-01 22:20:50 +0000 |
|---|---|---|
| committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-01 22:20:50 +0000 |
| commit | 9b9ae9556a0b51fc0201e925624ae6bd76686536 (patch) | |
| tree | cc0643d59f985f5c28f73e4056dac5a20bfe0e0d /net/proxy/proxy_resolver_v8.h | |
| parent | 947405b19c553f4cba8d0027f472ed932b2d84d5 (diff) | |
| download | chromium_src-9b9ae9556a0b51fc0201e925624ae6bd76686536.zip chromium_src-9b9ae9556a0b51fc0201e925624ae6bd76686536.tar.gz chromium_src-9b9ae9556a0b51fc0201e925624ae6bd76686536.tar.bz2 | |
Optimization: reduce the copying of string data between C++ and javascript in proxy_resolver_v8.cc.
This is done by sharing the string storage using ExternalStringResource.
An accompanying change was to pass around the PAC script data as a UTF16 string16 rather than a UTF8 std::string -- this required changing plumbing in the other files.
This optimization will be important when creating multiple ProxyResolverV8's so they don't end up duplicating the script text.
BUG=11079
Review URL: http://codereview.chromium.org/2817043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51434 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy/proxy_resolver_v8.h')
| -rw-r--r-- | net/proxy/proxy_resolver_v8.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/proxy/proxy_resolver_v8.h b/net/proxy/proxy_resolver_v8.h index 4424a30..bc4d731 100644 --- a/net/proxy/proxy_resolver_v8.h +++ b/net/proxy/proxy_resolver_v8.h @@ -5,8 +5,6 @@ #ifndef NET_PROXY_PROXY_RESOLVER_V8_H_ #define NET_PROXY_PROXY_RESOLVER_V8_H_ -#include <string> - #include "base/scoped_ptr.h" #include "net/proxy/proxy_resolver.h" @@ -63,7 +61,7 @@ class ProxyResolverV8 : public ProxyResolver { // ProxyResolver implementation: virtual int SetPacScript(const GURL& /*pac_url*/, - const std::string& bytes_utf8, + const string16& pac_script, CompletionCallback* /*callback*/); scoped_ptr<Context> context_; |