diff options
| author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-01 03:54:11 +0000 |
|---|---|---|
| committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-01 03:54:11 +0000 |
| commit | 8c49a50da6675ed9329b01a1e960c78e42d4ba82 (patch) | |
| tree | 042bbb738805c8476c0969931df61e261a9abf98 /net/proxy | |
| parent | 184a2643cf0b7111cab9f602dde92ffa3d899e4b (diff) | |
| download | chromium_src-8c49a50da6675ed9329b01a1e960c78e42d4ba82.zip chromium_src-8c49a50da6675ed9329b01a1e960c78e42d4ba82.tar.gz chromium_src-8c49a50da6675ed9329b01a1e960c78e42d4ba82.tar.bz2 | |
Make an interface's virtual dtor protected rather than public.
This avoid a warning in chromium's clang plugin, since ProxyResolverV8Tracing::Job is refcounted and implements this interface.
Review URL: https://chromiumcodereview.appspot.com/12092098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180066 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/proxy')
| -rw-r--r-- | net/proxy/proxy_resolver_v8.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/proxy/proxy_resolver_v8.h b/net/proxy/proxy_resolver_v8.h index a310460..823e93a 100644 --- a/net/proxy/proxy_resolver_v8.h +++ b/net/proxy/proxy_resolver_v8.h @@ -45,8 +45,6 @@ class NET_EXPORT_PRIVATE ProxyResolverV8 : public ProxyResolver { JSBindings() {} - virtual ~JSBindings() {} - // Handler for "dnsResolve()", "dnsResolveEx()", "myIpAddress()", // "myIpAddressEx()". Returns true on success and fills |*output| with the // result. @@ -60,6 +58,9 @@ class NET_EXPORT_PRIVATE ProxyResolverV8 : public ProxyResolver { // Handler for when an error is encountered. |line_number| may be -1 // if a line number is not applicable to this error. virtual void OnError(int line_number, const string16& error) = 0; + + protected: + virtual ~JSBindings() {} }; // Constructs a ProxyResolverV8. |