diff options
author | rtenneti <rtenneti@chromium.org> | 2014-08-29 16:53:34 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-08-29 23:56:44 +0000 |
commit | 00f180a54e0ebf53bcadebc9983ee406818f232b (patch) | |
tree | 1f264b9435617559bc0df93f40d63e576ceea5ea /net/quic/quic_connection_logger.h | |
parent | 15c487676ac5c50e1f59461d3c7c3f89cf27838d (diff) | |
download | chromium_src-00f180a54e0ebf53bcadebc9983ee406818f232b.zip chromium_src-00f180a54e0ebf53bcadebc9983ee406818f232b.tar.gz chromium_src-00f180a54e0ebf53bcadebc9983ee406818f232b.tar.bz2 |
Revert of Landing Recent QUIC Changes. (patchset #1 id:1 of https://codereview.chromium.org/515303003/)
Reason for revert:
Reverting to see if it fixes the following issue. Crash rate has gone up by 10 times.
BUG=409191
Original issue's description:
> Landing Recent QUIC Changes.
>
> Nest a QUIC SerializedPacket inside a QUIC QueuedPacket.
>
> Merge internal change: 74239145
> https://codereview.chromium.org/509203003/
>
>
> Remove PacketType from QUIC because the QUEUED type is not used and the
> other types can be reduced to a bool.
>
> Merge internal change: 74148481
> https://codereview.chromium.org/515003003/
>
>
> Don't send a QUIC SCUP message until after handshake confirmed.
>
> A server config update was occasionally being sent before the crypto
> handshake was complete, causing the client to close the connection.
>
> Merge internal change: 74132773
> https://codereview.chromium.org/516713002/
>
>
> Change TransmissionInfo's all_transmissions SequenceNumberSet* to
> default to NULL, and only be present if there are multiple transmissions.
>
> Estimated to save ~2% of CPU.
>
> Merge internal change: 74076012
> https://codereview.chromium.org/509073004/
>
>
> Log the quic version for internal server tracing.
> Not used in production.
>
> Merge internal change: 74069715
> https://codereview.chromium.org/514043002/
>
>
> Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a
> deque.
>
> Estimated to save ~3% of CPU based on pprof profiling of 100 large gets
> on tools/quic/end_to_end_test.cc.
>
> Merge internal change: 74054196
> https://codereview.chromium.org/514033002/
>
>
> Unit test for empty packet closes QUIC connection bug.
>
> Merge internal change: 74041239
> https://codereview.chromium.org/495423011/
>
>
> Log the QUIC transmission type in QUIC internal server trace visitor.
> Not used in production.
>
> Merge internal change: 73895739
> https://codereview.chromium.org/514023002/
>
>
> Not used in production. Log whether a QUIC packet sent was a crypto
> packet or not for internal server side tracing.
>
> Merge internal change: 73894063
> https://codereview.chromium.org/515003002/
>
>
> Fix a QUIC bug in which PING frames were not being ACK'd.
>
> Merge internal change: 73837644
> https://codereview.chromium.org/512933005/
>
> R=rch@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/27f3f1894f09a96112df50fddd32895b4677f949
TBR=rch@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/523813003
Cr-Commit-Position: refs/heads/master@{#292722}
Diffstat (limited to 'net/quic/quic_connection_logger.h')
-rw-r--r-- | net/quic/quic_connection_logger.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/quic/quic_connection_logger.h b/net/quic/quic_connection_logger.h index 8e81dd9..afb6043 100644 --- a/net/quic/quic_connection_logger.h +++ b/net/quic/quic_connection_logger.h @@ -68,13 +68,12 @@ class NET_EXPORT_PRIVATE QuicConnectionLogger virtual void OnRevivedPacket(const QuicPacketHeader& revived_header, base::StringPiece payload) OVERRIDE; virtual void OnConnectionClosed(QuicErrorCode error, bool from_peer) OVERRIDE; - virtual void OnSuccessfulVersionNegotiation( - const QuicVersion& version) OVERRIDE; void OnCryptoHandshakeMessageReceived( const CryptoHandshakeMessage& message); void OnCryptoHandshakeMessageSent( const CryptoHandshakeMessage& message); + void OnSuccessfulVersionNegotiation(const QuicVersion& version); void UpdateReceivedFrameCounts(QuicStreamId stream_id, int num_frames_received, int num_duplicate_frames_received); |