diff options
| author | bnc <bnc@chromium.org> | 2015-07-07 23:17:07 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-08 06:17:48 +0000 |
| commit | 662fd31d966dfc39e5cfd877cb450086a23e1495 (patch) | |
| tree | ace59b1632170d412437a1c03e999e0ba3139814 /net/quic/quic_headers_stream_test.cc | |
| parent | 203f5c82bb4eeb0808dac09ef0a79b8548acce93 (diff) | |
| download | chromium_src-662fd31d966dfc39e5cfd877cb450086a23e1495.zip chromium_src-662fd31d966dfc39e5cfd877cb450086a23e1495.tar.gz chromium_src-662fd31d966dfc39e5cfd877cb450086a23e1495.tar.bz2 | |
Change |delta_window_size| to signed type.
Change |delta_window_size| argument of OnWindowUpdate from unsigned to signed
integer type. This is prescibed by the styleguide [1], and also converges to
the internal codebase. Note that the HTTP/2 specification [2] conveniently
defines the window size increment to be a 31 bit unsigned integer, so that it
can be represented by a signed 32 bit integer type.
[1]
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Integer_Types
[2] https://tools.ietf.org/html/rfc7540#section-6.9
BUG=488484
Review URL: https://codereview.chromium.org/1217443013
Cr-Commit-Position: refs/heads/master@{#337777}
Diffstat (limited to 'net/quic/quic_headers_stream_test.cc')
| -rw-r--r-- | net/quic/quic_headers_stream_test.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/quic/quic_headers_stream_test.cc b/net/quic/quic_headers_stream_test.cc index cd12b3d..4e417b2 100644 --- a/net/quic/quic_headers_stream_test.cc +++ b/net/quic/quic_headers_stream_test.cc @@ -63,8 +63,8 @@ class MockVisitor : public SpdyFramerVisitorInterface { bool exclusive, bool fin, bool end)); - MOCK_METHOD2(OnWindowUpdate, void(SpdyStreamId stream_id, - uint32 delta_window_size)); + MOCK_METHOD2(OnWindowUpdate, + void(SpdyStreamId stream_id, int delta_window_size)); MOCK_METHOD2(OnCredentialFrameData, bool(const char* credential_data, size_t len)); MOCK_METHOD1(OnBlocked, void(SpdyStreamId stream_id)); |