summaryrefslogtreecommitdiffstats
path: root/net/quic/quic_packet_creator_test.cc
diff options
context:
space:
mode:
authorrtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-08 19:01:52 +0000
committerrtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-08 19:01:52 +0000
commit14a957522e13fd223f1fb9af4b8e61f1c3351189 (patch)
tree579532bdece6b154af9c86f98547e1fa07ff1f76 /net/quic/quic_packet_creator_test.cc
parentbc14fb52b468bbde0d12276d44f70b943f86c697 (diff)
downloadchromium_src-14a957522e13fd223f1fb9af4b8e61f1c3351189.zip
chromium_src-14a957522e13fd223f1fb9af4b8e61f1c3351189.tar.gz
chromium_src-14a957522e13fd223f1fb9af4b8e61f1c3351189.tar.bz2
Land Recent QUIC Changes.
Fix QUIC faster stats reporting memory leaks and crashes by changing lifetime once again. Now QuicAckNotify::DelegateInterface, one of the base classes of QuicFasterStatsGatherer, is ref-counted so QuicFasterStatsGatherer is guanrateed to be around until either faster stats reporting happens or the last ack is delivered by the QuicConnection. Merge internal change: 59228960 https://codereview.chromium.org/126543005/ Add a test requested by rch@ in cr/59053386 to replicate a potential DCHECK failure. Merge internal change: 59147972 https://codereview.chromium.org/127563002/ QUIC - Syncing with internal source code. Fixing the include order. Added missing OVERRIDE. Merge internal change: 59061118 https://codereview.chromium.org/127553002/ Make TimeWaitListManager use PacketWriter's socket writability state. Merge internal change: 59058066 https://codereview.chromium.org/127523002/ Make QuicPacketWriter keep track of socket writability; expose the underlying writer's state instead of keeping a separate variable in Dispatcher. Eventually we'll thread this to session/connection as suggested in a TODO. Merge internal change: 59055651 https://codereview.chromium.org/127503002/ Fix a QUIC DCHECK flakiness caused by not checking if a packet is pending before asserting that it's in the sent_packet_map. Merge internal change: 59053386 https://codereview.chromium.org/127003002/ QUIC Cleanup to remove pending_packets from QuicSentPacketManager and use a flag in unacked_packets_. Replaced FindOrNull and FindOrDie with find() call. Merge internal change: 59015729 https://codereview.chromium.org/126983002/ R=rch@chromium.org Review URL: https://codereview.chromium.org/127633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243619 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/quic/quic_packet_creator_test.cc')
-rw-r--r--net/quic/quic_packet_creator_test.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/quic/quic_packet_creator_test.cc b/net/quic/quic_packet_creator_test.cc
index 17705f2..6eb849f 100644
--- a/net/quic/quic_packet_creator_test.cc
+++ b/net/quic/quic_packet_creator_test.cc
@@ -512,8 +512,8 @@ TEST_F(QuicPacketCreatorTest, CreateStreamFrameWithNotifier) {
// Ensure that if CreateStreamFrame does not consume any data (e.g. a FIN only
// frame) then any QuicAckNotifier that is passed in still gets attached to
// the frame.
- MockAckNotifierDelegate delegate;
- QuicAckNotifier notifier(&delegate);
+ scoped_refptr<MockAckNotifierDelegate> delegate(new MockAckNotifierDelegate);
+ QuicAckNotifier notifier(delegate.get());
QuicFrame frame;
IOVector empty_iovector;
bool fin = true;