Land Recent QUIC Changes.

Change the initial maximum packet size for a QUIC server to 1000 bytes
instead of 1350 bytes. Protected by FLAGS_quic_small_default_packet_size
which is enabled by default.

When the server receives the CHLO from the client, if the CHLO packet is
larger, the server will increase its max packet length to match.

Merge internal change: 86310847
https://codereview.chromium.org/916143004/

Adding DCHECKS in the crypto stream constructors to make sure is_server
is set correctly, and fixing up tests accordingly.

Merge internal change: 86300482
https://codereview.chromium.org/929033003/

Enable QUIC's pacing by default on all QUIC connections by setting
FLAGS_quic_enable_pacing to true by default.

Merge internal change: 86286914
https://codereview.chromium.org/933653003/

Fully qualify std::* names being exported internally by using
declarations in third_party/stl/*. These using declarations are a
historical artifact and they hinder portability and toolchain changes.

Merge internal change: 86267997
https://codereview.chromium.org/925423004/

Adding an option to the quic client to not respect GOAWAYS.

Didn't make this change in Chromium's QuicClientSession.

Merge internal change: 86198166
https://codereview.chromium.org/930983002/

Deprecating FLAGS_quic_ack_notifier_informed_on_serialized.

Merge internal change: 86177949
https://codereview.chromium.org/927173002/

Change QuicFramer so it accepts a QuicDataWriter rather than allocating
one.

Saves a full packet allocation by putting it on the stack.

Merge internal change: 86104715
https://codereview.chromium.org/921883003/

Deprecate FLAGS_quic_use_std_cbrt.

Merge internal change: 86087014
https://codereview.chromium.org/928163004/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/932723002

Cr-Commit-Position: refs/heads/master@{#316616}

1 files changed, 3 insertions, 9 deletions

diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index c1811cf..60fd0f5 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -15,7 +15,6 @@
 #include "net/quic/quic_flags.h"
 #include "net/quic/quic_utils_chromium.h"
 
-using std::make_pair;
 using std::max;
 using std::min;
 
@@ -329,7 +328,7 @@ void QuicSentPacketManager::HandleAckForSentPackets(
     // If data is associated with the most recent transmission of this
     // packet, then inform the caller.
     if (it->in_flight) {
-      packets_acked_.push_back(make_pair(sequence_number, *it));
+      packets_acked_.push_back(std::make_pair(sequence_number, *it));
     }
     MarkPacketHandled(sequence_number, *it, delta_largest_observed);
   }
@@ -561,12 +560,7 @@ bool QuicSentPacketManager::OnPacketSent(
   DCHECK(!unacked_packets_.IsUnacked(sequence_number));
   LOG_IF(DFATAL, bytes == 0) << "Cannot send empty packets.";
 
-  if (original_sequence_number == 0) {
-    if (!FLAGS_quic_ack_notifier_informed_on_serialized &&
-        serialized_packet->retransmittable_frames) {
-      ack_notifier_manager_.OnSerializedPacket(*serialized_packet);
-    }
-  } else {
+  if (original_sequence_number != 0) {
     PendingRetransmissionMap::iterator it =
         pending_retransmissions_.find(original_sequence_number);
     if (it != pending_retransmissions_.end()) {
@@ -793,7 +787,7 @@ void QuicSentPacketManager::InvokeLossDetection(QuicTime time) {
     // should be recorded as a loss to the send algorithm, but not retransmitted
     // until it's known whether the FEC packet arrived.
     ++stats_->packets_lost;
-    packets_lost_.push_back(make_pair(sequence_number, transmission_info));
+    packets_lost_.push_back(std::make_pair(sequence_number, transmission_info));
     DVLOG(1) << ENDPOINT << "Lost packet " << sequence_number;
 
     if (transmission_info.retransmittable_frames != nullptr) {