diff options
| author | rtenneti <rtenneti@chromium.org> | 2015-08-13 10:44:08 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-13 17:44:46 +0000 |
| commit | efd0781a90231e61889c810e1b5aff367d87094b (patch) | |
| tree | d825d3bcb9626613cfd5e8982f0c229e2fe957e6 /net/quic/quic_sent_packet_manager.cc | |
| parent | 3423814ea49820b72ac786600bf45b10a869f21a (diff) | |
| download | chromium_src-efd0781a90231e61889c810e1b5aff367d87094b.zip chromium_src-efd0781a90231e61889c810e1b5aff367d87094b.tar.gz chromium_src-efd0781a90231e61889c810e1b5aff367d87094b.tar.bz2 | |
Revert of QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in (patchset #1 id:1 of https://codereview.chromium.org/1281303002/ )
Reason for revert:
BUG=520301
Original issue's description:
> QUIC - Call base::debug::DumpWithoutCrashing instead of crashing in
> QuicSentPacketManager::MaybeRetransmitTailLossProbe.
>
> BUG=517726
> R=rch@chromium.org
>
> Committed: https://crrev.com/22f7d9ae62bb4867579032e3cae46dbb5720a8ff
> Cr-Commit-Position: refs/heads/master@{#342694}
TBR=rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=517726
Review URL: https://codereview.chromium.org/1287363002
Cr-Commit-Position: refs/heads/master@{#343227}
Diffstat (limited to 'net/quic/quic_sent_packet_manager.cc')
| -rw-r--r-- | net/quic/quic_sent_packet_manager.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc index b3d94d7..566210b 100644 --- a/net/quic/quic_sent_packet_manager.cc +++ b/net/quic/quic_sent_packet_manager.cc @@ -6,7 +6,6 @@ #include <algorithm> -#include "base/debug/dump_without_crashing.h" #include "base/logging.h" #include "base/stl_util.h" #include "net/quic/congestion_control/pacing_sender.h" @@ -655,12 +654,8 @@ bool QuicSentPacketManager::MaybeRetransmitTailLossProbe() { MarkForRetransmission(sequence_number, TLP_RETRANSMISSION); return true; } -#if defined(NDEBUG) - base::debug::DumpWithoutCrashing(); -#else DLOG(FATAL) << "No retransmittable packets, so RetransmitOldestPacket failed."; -#endif return false; } |