diff options
author | rtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-07 00:40:01 +0000 |
---|---|---|
committer | rtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-07 00:40:01 +0000 |
commit | a4f8f99b48afb5daaad7e05919e01dc0715d7a00 (patch) | |
tree | fcf29701d05444277d96db9bc232b249e0a0dd14 /net/socket/client_socket_handle.h | |
parent | 075a12f065899ff19eac647efad651a79353dbbd (diff) | |
download | chromium_src-a4f8f99b48afb5daaad7e05919e01dc0715d7a00.zip chromium_src-a4f8f99b48afb5daaad7e05919e01dc0715d7a00.tar.gz chromium_src-a4f8f99b48afb5daaad7e05919e01dc0715d7a00.tar.bz2 |
Revert 113300 - Revert of 112134 of Revert 112130 - Close idle connections / SPDY sessions when needed.
Due to the idle connection state being held by different socket pools, it's possible for one socket pool to hold an idle socket in a lower layer socket pool. From the lower level socket pool's perspective, the socket is being "actively" used. From the higher socket pool's (including SpdySession, which is more of a connection manager) perspective, the connection is idle and can be closed if we have hit a limit.
Normally this isn't a big deal, except when we have a lot of idle SPDY connections and are connecting via a proxy, so we have low connection limits through the proxy server. We address this problem by allowing lower-level socket pools to tell higher level socket pools to close a socket.
Fixed ASAN test failures by removing .Times(1) and .Times(2) from CloseMultipleIdleSocketsHeldByLayeredPoolWhenNeeded unittest (this removes the tests relying on the order of std::set in CloseOneIdleConnectionInLayeredPool). ASAN is probably causing the memory allocator to allocate the pools differently. The std::set is ordered by LayeredPool* which is the address of the LayeredPool (willchan).
BUG=62364,92244, 105839
TEST=none
Review URL: http://codereview.chromium.org/8340012
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8745007
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/8803019
TBR=rtenneti@chromium.org
Review URL: http://codereview.chromium.org/8825014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113305 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/client_socket_handle.h')
-rw-r--r-- | net/socket/client_socket_handle.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/net/socket/client_socket_handle.h b/net/socket/client_socket_handle.h index 23fc5cf..cab6ef6 100644 --- a/net/socket/client_socket_handle.h +++ b/net/socket/client_socket_handle.h @@ -92,10 +92,6 @@ class NET_EXPORT ClientSocketHandle { // initialized the ClientSocketHandle. LoadState GetLoadState() const; - bool IsPoolStalled() const; - - void AddLayeredPool(LayeredPool* layered_pool); - // Returns true when Init() has completed successfully. bool is_initialized() const { return is_initialized_; } @@ -168,7 +164,6 @@ class NET_EXPORT ClientSocketHandle { bool is_initialized_; ClientSocketPool* pool_; - LayeredPool* layered_pool_; scoped_ptr<StreamSocket> socket_; std::string group_name_; bool is_reused_; |