diff options
| author | thomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-20 15:01:16 +0000 |
|---|---|---|
| committer | thomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-20 15:01:16 +0000 |
| commit | 9f864b3e9d0650004a957035d08357c2bde81b99 (patch) | |
| tree | c373f03088eae4d9688285165877660b814c5b87 /net/socket/client_socket_pool_base_unittest.cc | |
| parent | 5f9a7f97780db19175a8549d39b97f62fa6c9afb (diff) | |
| download | chromium_src-9f864b3e9d0650004a957035d08357c2bde81b99.zip chromium_src-9f864b3e9d0650004a957035d08357c2bde81b99.tar.gz chromium_src-9f864b3e9d0650004a957035d08357c2bde81b99.tar.bz2 | |
Turn GetPeerName into a pure virtual and provide local impls, this way any future bugs like the one referenced are compile time and not runtime so they won't wide waiting to be found.
BUG=32595
TEST=everything builds and tests pass
Review URL: http://codereview.chromium.org/552048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36629 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/client_socket_pool_base_unittest.cc')
| -rw-r--r-- | net/socket/client_socket_pool_base_unittest.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc index 6f3f5ef..7acebbd 100644 --- a/net/socket/client_socket_pool_base_unittest.cc +++ b/net/socket/client_socket_pool_base_unittest.cc @@ -57,12 +57,10 @@ class MockClientSocket : public ClientSocket { virtual bool IsConnected() const { return connected_; } virtual bool IsConnectedAndIdle() const { return connected_; } -#if defined(OS_LINUX) virtual int GetPeerName(struct sockaddr* /* name */, socklen_t* /* namelen */) { - return 0; + return ERR_UNEXPECTED; } -#endif private: bool connected_; |