diff options
| author | jschuh@chromium.org <jschuh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-05 13:11:54 +0000 |
|---|---|---|
| committer | jschuh@chromium.org <jschuh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-05 13:11:54 +0000 |
| commit | 5f49336067c0871355aaa72af45771fa8d8e4cca (patch) | |
| tree | de61361884c2bb96f2bbedd42d98ecfff5bc94cc /net/socket/client_socket_pool_base_unittest.cc | |
| parent | 228f013f8ac0eaac0f6522be8b8b5ea1f7ca522a (diff) | |
| download | chromium_src-5f49336067c0871355aaa72af45771fa8d8e4cca.zip chromium_src-5f49336067c0871355aaa72af45771fa8d8e4cca.tar.gz chromium_src-5f49336067c0871355aaa72af45771fa8d8e4cca.tar.bz2 | |
Revert 261966 "make SetReceiveBufferSize and SetSendBufferSize r..."
Appears to have broken the following gcm_unit_tests on Mac:
DeviceCredentials
AckOnLogin
AckWhenLimitReachedWithHeartbeat
ExpiredTTLOnRestart
InitializeExisting
SendMessageRMQAckOnReconnect
SendMessageRMQOnRestart
SendMessageRMQPartialAckOnReconnect
SendMessageRMQWithStreamAck
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/39860
> make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)
>
> TBR=sergeyu,yzshen
> R=wtc
> BUG=355222
>
> Review URL: https://codereview.chromium.org/217573002
TBR=jar@chromium.org
Review URL: https://codereview.chromium.org/227083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262002 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/client_socket_pool_base_unittest.cc')
| -rw-r--r-- | net/socket/client_socket_pool_base_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc index 5a672b4..605af72 100644 --- a/net/socket/client_socket_pool_base_unittest.cc +++ b/net/socket/client_socket_pool_base_unittest.cc @@ -145,8 +145,8 @@ class MockClientSocket : public StreamSocket { was_used_to_convey_data_ = true; return len; } - virtual int SetReceiveBufferSize(int32 size) OVERRIDE { return OK; } - virtual int SetSendBufferSize(int32 size) OVERRIDE { return OK; } + virtual bool SetReceiveBufferSize(int32 size) OVERRIDE { return true; } + virtual bool SetSendBufferSize(int32 size) OVERRIDE { return true; } // StreamSocket implementation. virtual int Connect(const CompletionCallback& callback) OVERRIDE { |