summaryrefslogtreecommitdiffstats
path: root/net/socket/ssl_client_socket.h
diff options
context:
space:
mode:
authorrch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-07-19 17:55:17 +0000
committerrch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-07-19 17:55:17 +0000
commit2d88e7d8b4c382e0ef178c52a87450c226150ef2 (patch)
treeb76d5921ed1ed5c2321570306779aab993f74568 /net/socket/ssl_client_socket.h
parentf7b2b6a665c130d4ca6b08fdec87b2fad3198f3d (diff)
downloadchromium_src-2d88e7d8b4c382e0ef178c52a87450c226150ef2.zip
chromium_src-2d88e7d8b4c382e0ef178c52a87450c226150ef2.tar.gz
chromium_src-2d88e7d8b4c382e0ef178c52a87450c226150ef2.tar.bz2
Change SpdySession::GetSSLInfo to get the SSLInfo from the underlying socket
even if the session is not "secure". This required refactoring StreamSocket to add WasNpnNegotiated() and GetSSLInfo() methods. This allows for a change to SpdySession::GetSSLInfo to accurately return the correct SSLInfo in the case of SPDY Proxy sessions. BUG=134690 TEST=\*DoNotUseSpdySessionIfCertDoesNotMatch\* Review URL: https://chromiumcodereview.appspot.com/10690122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147479 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/ssl_client_socket.h')
-rw-r--r--net/socket/ssl_client_socket.h13
1 files changed, 3 insertions, 10 deletions
diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h
index 6748e6e..41ee087 100644
--- a/net/socket/ssl_client_socket.h
+++ b/net/socket/ssl_client_socket.h
@@ -69,20 +69,15 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {
// the first protocol in our list.
};
- // Gets the SSL connection information of the socket.
- //
- // TODO(sergeyu): Move this method to the SSLSocket interface and
- // implemented in SSLServerSocket too.
- virtual void GetSSLInfo(SSLInfo* ssl_info) = 0;
+ // StreamSocket:
+ virtual bool WasNpnNegotiated() const OVERRIDE;
+ virtual NextProto GetNegotiatedProtocol() const OVERRIDE;
// Gets the SSL CertificateRequest info of the socket after Connect failed
// with ERR_SSL_CLIENT_AUTH_CERT_NEEDED.
virtual void GetSSLCertRequestInfo(
SSLCertRequestInfo* cert_request_info) = 0;
- // StreamSocket:
- virtual NextProto GetNegotiatedProtocol() const OVERRIDE;
-
// Get the application level protocol that we negotiated with the server.
// *proto is set to the resulting protocol (n.b. that the string may have
// embedded NULs).
@@ -110,8 +105,6 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {
// sessions.
static void ClearSessionCache();
- virtual bool was_npn_negotiated() const;
-
virtual bool set_was_npn_negotiated(bool negotiated);
virtual bool was_spdy_negotiated() const;