summaryrefslogtreecommitdiffstats
path: root/net/socket/ssl_client_socket.h
diff options
context:
space:
mode:
authorachuith@chromium.org <achuith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-01 18:53:42 +0000
committerachuith@chromium.org <achuith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-01 18:53:42 +0000
commitd1666539b57bf8552e203d355fd09909d36f9732 (patch)
tree4c923efc9c402f6a9111cf10d5864f044da41b10 /net/socket/ssl_client_socket.h
parentfc921169fc1ba829856b8d27af000781de2cb2e2 (diff)
downloadchromium_src-d1666539b57bf8552e203d355fd09909d36f9732.zip
chromium_src-d1666539b57bf8552e203d355fd09909d36f9732.tar.gz
chromium_src-d1666539b57bf8552e203d355fd09909d36f9732.tar.bz2
NotificationPromo.
* Split out NotificationPromo helper class for PromoResourceService to handle promo notification. * Support for views/max_views. * NotificationPromo has data members for all the prefs fields (start, end, build, time_slice, max_group, max_views, group, views, text and closed). * Move notification parsing methods from PromoResourceService to NotificationPromo. * NotificationPromo can be initialized from json when the promo resource is parsed, or from prefs, when CanShowNotificationPromo is called. * NotificationPromo now only writes out prefs upon detecting a new notification. * NotificationPromo has a Delegate class, useful for testing. * Static helper methods introduced for extracting time from DictionaryValue, string and prefs. These may be easily unit-tested in the future. * Number of additional tests to more thoroughly test parsing, CanShow logic, and static helper functions like GetNextQuestionValue and NewGroup. * NewGroup now uses RandInt instead of rand(), so this CL passes lint with no complaints. * Some additional cleanup of PromoResourceService, esp GetChannel and IsBuildTargeted. BUG=96290 TEST=Unit tests pass. Use --promo-server-url='http://achuithz600.mtv.corp.google.com/www/files/promoresource2?hl=' to see the promo. If you exceed 5 views, you have to reset the views count (ntp.promo_views) in your Preferences. Review URL: http://codereview.chromium.org/8045012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103646 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/ssl_client_socket.h')
0 files changed, 0 insertions, 0 deletions