diff options
author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-10 17:18:53 +0000 |
---|---|---|
committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-10 17:18:53 +0000 |
commit | edafd4c1a5c906e808e2448810e2099d8dc704b9 (patch) | |
tree | 4ccc930c0b9ff8663183ebb6333e9ac990f0e491 /net/socket/stream_socket.cc | |
parent | 063bb25a11a9258c44d61210dfd98f41e7b4f24a (diff) | |
download | chromium_src-edafd4c1a5c906e808e2448810e2099d8dc704b9.zip chromium_src-edafd4c1a5c906e808e2448810e2099d8dc704b9.tar.gz chromium_src-edafd4c1a5c906e808e2448810e2099d8dc704b9.tar.bz2 |
Add one-time randomization support for FieldTrial, and the ability to
disable field trials. I am going to have a need for both soon.
Update some documentation about empty trial names, add TrialExists() method and update many call-sites to use this (it simplifies the previous logic which checked for existence and then for non-empty name, which can no longer happen).
Refactor a bit in browser_main.
While I'm in there and needing base/OWNERS approval, add an OWNERS
file for base/metrics that adds jar@chromium.org as an owner for that
directory.
Initially committed as r84197.
Rolled back due to DCHECK in official builds, r84373.
Will re-submit with fix.
BUG=81750
TEST=base_unittests
Review URL: http://codereview.chromium.org/6883102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84801 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/socket/stream_socket.cc')
-rw-r--r-- | net/socket/stream_socket.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/net/socket/stream_socket.cc b/net/socket/stream_socket.cc index 37482b4..3ef24c0 100644 --- a/net/socket/stream_socket.cc +++ b/net/socket/stream_socket.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -134,8 +134,7 @@ void StreamSocket::UseHistory::EmitPreconnectionHistograms() const { UMA_HISTOGRAM_ENUMERATION("Net.PreconnectUtilization2", result, 9); static const bool connect_backup_jobs_fieldtrial = - base::FieldTrialList::Find("ConnnectBackupJobs") && - !base::FieldTrialList::Find("ConnnectBackupJobs")->group_name().empty(); + base::FieldTrialList::TrialExists("ConnnectBackupJobs"); if (connect_backup_jobs_fieldtrial) { UMA_HISTOGRAM_ENUMERATION( base::FieldTrial::MakeName("Net.PreconnectUtilization2", |