diff options
author | brettw <brettw@chromium.org> | 2015-06-23 17:39:02 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-06-24 00:39:38 +0000 |
commit | b3413064f36bf166d7dffb463bc442059dab1dd7 (patch) | |
tree | 391826aaaccf59398a8d59437482ce9dd62da48f /net/tools/dump_cache | |
parent | 737f36b52ce9137b242b8259b8f440c61e6b60ba (diff) | |
download | chromium_src-b3413064f36bf166d7dffb463bc442059dab1dd7.zip chromium_src-b3413064f36bf166d7dffb463bc442059dab1dd7.tar.gz chromium_src-b3413064f36bf166d7dffb463bc442059dab1dd7.tar.bz2 |
Move more string_util functions to base namespace.
Rename IsWhitespace to IsUnicodeWhitespace (to contrast it to the already-existing IsAsciiWhitespace).
De-inline HexDigitToInt. This is only used in a few places and I don't think it's necessary to inline.
Remove some redundant base:: qualifications in base.
TBR=sky
Review URL: https://codereview.chromium.org/1200053004
Cr-Commit-Position: refs/heads/master@{#335827}
Diffstat (limited to 'net/tools/dump_cache')
-rw-r--r-- | net/tools/dump_cache/url_to_filename_encoder.cc | 2 | ||||
-rw-r--r-- | net/tools/dump_cache/url_utilities.cc | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/net/tools/dump_cache/url_to_filename_encoder.cc b/net/tools/dump_cache/url_to_filename_encoder.cc index b807ec0..083b9c5 100644 --- a/net/tools/dump_cache/url_to_filename_encoder.cc +++ b/net/tools/dump_cache/url_to_filename_encoder.cc @@ -18,7 +18,7 @@ namespace { // The function checks for '\0' for string termination. int HexDigitsPrefix(const char* buf, int num_digits) { for (int i = 0; i < num_digits; i++) { - if (!IsHexDigit(buf[i])) + if (!base::IsHexDigit(buf[i])) return 0; // This also detects end of string as '\0' is not xdigit. } return 1; diff --git a/net/tools/dump_cache/url_utilities.cc b/net/tools/dump_cache/url_utilities.cc index 7604494..807f187 100644 --- a/net/tools/dump_cache/url_utilities.cc +++ b/net/tools/dump_cache/url_utilities.cc @@ -87,7 +87,7 @@ std::string UrlUtilities::Unescape(const std::string& escaped_url) { ++iter; break; case ESCAPE1: - if (IsHexDigit(c)) { + if (base::IsHexDigit(c)) { escape_text.push_back(c); state = ESCAPE2; ++iter; @@ -98,7 +98,7 @@ std::string UrlUtilities::Unescape(const std::string& escaped_url) { } break; case ESCAPE2: - if (IsHexDigit(c)) { + if (base::IsHexDigit(c)) { escape_text.push_back(c); bool ok = base::HexStringToInt(escape_text, &escape_value); DCHECK(ok); |