diff options
author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-15 16:47:02 +0000 |
---|---|---|
committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-15 16:47:02 +0000 |
commit | e599218171e942749da5c8b3931b091655c1b74c (patch) | |
tree | 703ee7f0427e0bafabb1402e678c40c31acec38e /net/tools | |
parent | 24ea7da0968595f5365a537fba548e9163f1f371 (diff) | |
download | chromium_src-e599218171e942749da5c8b3931b091655c1b74c.zip chromium_src-e599218171e942749da5c8b3931b091655c1b74c.tar.gz chromium_src-e599218171e942749da5c8b3931b091655c1b74c.tar.bz2 |
Change base::LaunchProcess API slightly
Rather than passing the out param process handle via the options,
take it as a function argument. This simplifies many callers.
BUG=88990
Review URL: http://codereview.chromium.org/7377012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92701 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/tools')
-rw-r--r-- | net/tools/crash_cache/crash_cache.cc | 4 | ||||
-rw-r--r-- | net/tools/dump_cache/dump_cache.cc | 2 |
2 files changed, 2 insertions, 4 deletions
diff --git a/net/tools/crash_cache/crash_cache.cc b/net/tools/crash_cache/crash_cache.cc index 637daae..f1b4b79 100644 --- a/net/tools/crash_cache/crash_cache.cc +++ b/net/tools/crash_cache/crash_cache.cc @@ -49,9 +49,7 @@ int RunSlave(RankCrashes action) { cmdline.AppendArg(base::IntToString(action)); base::ProcessHandle handle; - base::LaunchOptions options; - options.process_handle = &handle; - if (!base::LaunchProcess(cmdline, options)) { + if (!base::LaunchProcess(cmdline, base::LaunchOptions(), &handle)) { printf("Unable to run test %d\n", action); return GENERIC; } diff --git a/net/tools/dump_cache/dump_cache.cc b/net/tools/dump_cache/dump_cache.cc index 4a63d00..ee5a50e 100644 --- a/net/tools/dump_cache/dump_cache.cc +++ b/net/tools/dump_cache/dump_cache.cc @@ -97,7 +97,7 @@ int LaunchSlave(const CommandLine& command_line, // TODO(evanm): remove needless usage of wstring from here and elsewhere. new_command_line.AppendSwitchASCII(kPipe, WideToASCII(pipe_number)); - if (!base::LaunchProcess(new_command_line, base::LaunchOptions())) { + if (!base::LaunchProcess(new_command_line, base::LaunchOptions(), NULL)) { printf("Unable to launch the needed version of this tool: %ls\n", new_program.c_str()); printf(kUpgradeHelp); |