diff options
| author | rtenneti <rtenneti@chromium.org> | 2015-03-10 13:02:47 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-10 20:03:21 +0000 |
| commit | 4d67b156f911a54c19ef38ae2810b25137eeff6c (patch) | |
| tree | 7e25fa4a84984bfe1b2b2cff366e106316337e9b /net/udp | |
| parent | 69a1d55ad81c517f181992496bfd1ec23dd51fad (diff) | |
| download | chromium_src-4d67b156f911a54c19ef38ae2810b25137eeff6c.zip chromium_src-4d67b156f911a54c19ef38ae2810b25137eeff6c.tar.gz chromium_src-4d67b156f911a54c19ef38ae2810b25137eeff6c.tar.bz2 | |
Instrument UDP socket's read callback code (in QUIC) to find jank in
UDPSocketWin::Core::ReadDelegate::OnObjectSignaled.
BUG=462789
R=rch@chromium.org, vadimt@chromium.org
Review URL: https://codereview.chromium.org/994813002
Cr-Commit-Position: refs/heads/master@{#319951}
Diffstat (limited to 'net/udp')
| -rw-r--r-- | net/udp/udp_socket_win.cc | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/net/udp/udp_socket_win.cc b/net/udp/udp_socket_win.cc index 581df43..ad99e2a 100644 --- a/net/udp/udp_socket_win.cc +++ b/net/udp/udp_socket_win.cc @@ -145,7 +145,7 @@ void UDPSocketWin::Core::WatchForWrite() { } void UDPSocketWin::Core::ReadDelegate::OnObjectSignaled(HANDLE object) { - // TODO(pkasting): Remove ScopedTracker below once crbug.com/462789 is fixed. + // TODO(rtenneti): Remove ScopedTracker below once crbug.com/462789 is fixed. tracked_objects::ScopedTracker tracking_profile( FROM_HERE_WITH_EXPLICIT_FUNCTION( "462789 UDPSocketWin::Core::ReadDelegate::OnObjectSignaled")); @@ -329,6 +329,10 @@ int UDPSocketWin::GetPeerAddress(IPEndPoint* address) const { if (!is_connected()) return ERR_SOCKET_NOT_CONNECTED; + // TODO(rtenneti): Remove ScopedTracker below once crbug.com/462789 is fixed. + tracked_objects::ScopedTracker tracking_profile( + FROM_HERE_WITH_EXPLICIT_FUNCTION("462789 UDPSocketWin::GetPeerAddress")); + // TODO(szym): Simplify. http://crbug.com/126152 if (!remote_address_.get()) { SockaddrStorage storage; @@ -350,6 +354,10 @@ int UDPSocketWin::GetLocalAddress(IPEndPoint* address) const { if (!is_connected()) return ERR_SOCKET_NOT_CONNECTED; + // TODO(rtenneti): Remove ScopedTracker below once crbug.com/462789 is fixed. + tracked_objects::ScopedTracker tracking_profile( + FROM_HERE_WITH_EXPLICIT_FUNCTION("462789 UDPSocketWin::GetLocalAddress")); + // TODO(szym): Simplify. http://crbug.com/126152 if (!local_address_.get()) { SockaddrStorage storage; @@ -562,6 +570,11 @@ void UDPSocketWin::DoReadCallback(int rv) { // since Run may result in Read being called, clear read_callback_ up front. CompletionCallback c = read_callback_; read_callback_.Reset(); + + // TODO(rtenneti): Remove ScopedTracker below once crbug.com/462789 is fixed. + tracked_objects::ScopedTracker tracking_profile( + FROM_HERE_WITH_EXPLICIT_FUNCTION("462789 UDPSocketWin::DoReadCallback")); + c.Run(rv); } |