diff options
author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-31 22:05:19 +0000 |
---|---|---|
committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-31 22:05:19 +0000 |
commit | 2ca01e54e2a4b4aa3996dc6a5eb83def3dd4cab1 (patch) | |
tree | 65eae8674a5f174856f79a2d14758b271aa33843 /net/url_request/url_request_context_builder_unittest.cc | |
parent | 93b7afd44a79bfdc4ce282cd6a848671b14762f9 (diff) | |
download | chromium_src-2ca01e54e2a4b4aa3996dc6a5eb83def3dd4cab1.zip chromium_src-2ca01e54e2a4b4aa3996dc6a5eb83def3dd4cab1.tar.gz chromium_src-2ca01e54e2a4b4aa3996dc6a5eb83def3dd4cab1.tar.bz2 |
[Net] Add a priority parameter to URLRequest's constructor
This is so that it is clearer what the intended initial priority of
a URLRequest is.
It is also needed so that we can later enforce that if a URLRequest
is set to ignore limits, it has MAXIMUM_PRIORITY; otherwise, we'd have
to mandate that SetPriority() is called before set_load_flags(), which
is fiddly.
Also standardize on a single URLRequest constructor.
BUG=166689
R=jam@chromium.org, jamesr@chromium.org, joth@chromium.org, mmenke@chromium.org, scottbyer@chromium.org, sky@chromium.org, tommi@chromium.org
Review URL: https://codereview.chromium.org/51953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232219 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request/url_request_context_builder_unittest.cc')
-rw-r--r-- | net/url_request/url_request_context_builder_unittest.cc | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/net/url_request/url_request_context_builder_unittest.cc b/net/url_request/url_request_context_builder_unittest.cc index f747b4d..e882253 100644 --- a/net/url_request/url_request_context_builder_unittest.cc +++ b/net/url_request/url_request_context_builder_unittest.cc @@ -5,6 +5,7 @@ #include "net/url_request/url_request_context_builder.h" #include "build/build_config.h" +#include "net/base/request_priority.h" #include "net/test/spawned_test_server/spawned_test_server.h" #include "net/url_request/url_request.h" #include "net/url_request/url_request_test_util.h" @@ -55,8 +56,10 @@ TEST_F(URLRequestContextBuilderTest, DefaultSettings) { scoped_ptr<URLRequestContext> context(builder_.Build()); TestDelegate delegate; - URLRequest request( - test_server_.GetURL("echoheader?Foo"), &delegate, context.get()); + URLRequest request(test_server_.GetURL("echoheader?Foo"), + DEFAULT_PRIORITY, + &delegate, + context.get()); request.set_method("GET"); request.SetExtraRequestHeaderByName("Foo", "Bar", false); request.Start(); @@ -70,8 +73,10 @@ TEST_F(URLRequestContextBuilderTest, UserAgent) { builder_.set_user_agent("Bar"); scoped_ptr<URLRequestContext> context(builder_.Build()); TestDelegate delegate; - URLRequest request( - test_server_.GetURL("echoheader?User-Agent"), &delegate, context.get()); + URLRequest request(test_server_.GetURL("echoheader?User-Agent"), + DEFAULT_PRIORITY, + &delegate, + context.get()); request.set_method("GET"); request.Start(); base::MessageLoop::current()->Run(); |