diff options
author | olli.raula <olli.raula@intel.com> | 2015-09-10 04:14:22 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-09-10 11:15:10 +0000 |
commit | 36aa8be4eb53b3ea75b84a9646e0204725f3bc43 (patch) | |
tree | 74da8174db2a6edd8d55cf141ec1976b3b37365d /net/url_request/url_request_job_manager.h | |
parent | 68fc3715f76e3da9131b035ddd9606dfee6180bd (diff) | |
download | chromium_src-36aa8be4eb53b3ea75b84a9646e0204725f3bc43.zip chromium_src-36aa8be4eb53b3ea75b84a9646e0204725f3bc43.tar.gz chromium_src-36aa8be4eb53b3ea75b84a9646e0204725f3bc43.tar.bz2 |
Move Singleton and related structs to namespace base
Public APIs from base should live inside base:: so moved Singleton class
and structs to base{} and fixed consumers.
also fixed:
** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template
gets instantiated in a single compilation unit.
chrome/browser/plugins/plugin_finder.h \
chromecast/media/base/media_message_loop.h \
content/browser/media/android/media_drm_credential_manager.h
Presubmit warnings:
src/chrome/browser/extensions/warning_badge_service_factory.h:5:
#ifndef header guard has wrong style, please use:
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_
[build/header_guard] [5]
src/chrome/browser/extensions/warning_badge_service_factory.h:39:
#endif line should be "#endif //
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_"
[build/header_guard] [5]
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1308823002
Cr-Commit-Position: refs/heads/master@{#348136}
Diffstat (limited to 'net/url_request/url_request_job_manager.h')
-rw-r--r-- | net/url_request/url_request_job_manager.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/url_request/url_request_job_manager.h b/net/url_request/url_request_job_manager.h index 7729abb..422a982 100644 --- a/net/url_request/url_request_job_manager.h +++ b/net/url_request/url_request_job_manager.h @@ -11,7 +11,9 @@ #include "net/base/net_export.h" #include "net/url_request/url_request.h" +namespace base { template <typename T> struct DefaultSingletonTraits; +} // namespace base namespace net { @@ -51,7 +53,7 @@ class NET_EXPORT URLRequestJobManager { static bool SupportsScheme(const std::string& scheme); private: - friend struct DefaultSingletonTraits<URLRequestJobManager>; + friend struct base::DefaultSingletonTraits<URLRequestJobManager>; URLRequestJobManager(); ~URLRequestJobManager(); |