diff options
author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-05 13:53:00 +0000 |
---|---|---|
committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-05 13:53:00 +0000 |
commit | a1077c348100168e972f3dbb228dfb76f6584cc2 (patch) | |
tree | bebf82cb01685a0f4e96b33f0ccdbcdf9e313215 /net/url_request/url_request_throttler_manager.cc | |
parent | f49609366a3926187fbe7b86641542572bcd85ee (diff) | |
download | chromium_src-a1077c348100168e972f3dbb228dfb76f6584cc2.zip chromium_src-a1077c348100168e972f3dbb228dfb76f6584cc2.tar.gz chromium_src-a1077c348100168e972f3dbb228dfb76f6584cc2.tar.bz2 |
Removing check for NULL pointer. The memory stomper has been fixed.
BUG=71721
TEST=none
Review URL: http://codereview.chromium.org/6794029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80446 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net/url_request/url_request_throttler_manager.cc')
-rw-r--r-- | net/url_request/url_request_throttler_manager.cc | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/net/url_request/url_request_throttler_manager.cc b/net/url_request/url_request_throttler_manager.cc index 3a21740..07c0605 100644 --- a/net/url_request/url_request_throttler_manager.cc +++ b/net/url_request/url_request_throttler_manager.cc @@ -150,13 +150,7 @@ void URLRequestThrottlerManager::GarbageCollectEntriesIfNecessary() { void URLRequestThrottlerManager::GarbageCollectEntries() { UrlEntryMap::iterator i = url_entries_.begin(); while (i != url_entries_.end()) { - // TODO(joi): We know, as per crbug.com/71721, that values here - // can sometimes be NULL because of a memory overwrite coming - // from somewhere else. Minidumps of the crash are at this point - // not giving us any new information so adding the [i->second == - // NULL] check lessens the impact on our users (it seems to - // generally avoid the crash). - if (i->second == NULL || (i->second)->IsEntryOutdated()) { + if ((i->second)->IsEntryOutdated()) { url_entries_.erase(i++); } else { ++i; |