Remove GetInputStreamBufferSize() method from FilterContext.

This virtual method, implemented only by URLRequestJob and MockFilterContext,
was only used for testing purposes. The kFilterBufSize constant now lives
in filter.cc (the only place it was used), and for the few tests that needed
to override the buffer size, I've added a test-only method in filter.h.

The result is a smaller interface surface in URLRequestJob and simpler tests for most cases in gzip_filter_unittest.cc and sdch_filter_unittest.cc.  I've done some further refactoring of the former to remove redundancy (most of Filter's complexity is exercised only in the SDCH test).

Review URL: http://codereview.chromium.org/6516025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77315 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 0 insertions, 12 deletions

diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc
index c13b8f5..ed01f0e 100644
--- a/net/url_request/url_request_job.cc
+++ b/net/url_request/url_request_job.cc
@@ -26,10 +26,6 @@ using base::TimeTicks;
 
 namespace net {
 
-// Buffer size allocated when de-compressing data.
-// static
-const int URLRequestJob::kFilterBufSize = 32 * 1024;
-
 URLRequestJob::URLRequestJob(URLRequest* request)
     : request_(request),
       prefilter_bytes_read_(0),
@@ -263,10 +259,6 @@ int URLRequestJob::GetResponseCode() const {
   return -1;
 }
 
-int URLRequestJob::GetInputStreamBufferSize() const {
-  return kFilterBufSize;
-}
-
 void URLRequestJob::RecordPacketStats(StatisticSelector statistic) const {
   if (!packet_timing_enabled_ || (final_packet_time_ == base::Time()))
     return;
diff --git a/net/url_request/url_request_job.h b/net/url_request/url_request_job.h
index b6c286a..3d29201 100644
--- a/net/url_request/url_request_job.h
+++ b/net/url_request/url_request_job.h
@@ -207,7 +207,6 @@ class URLRequestJob : public base::RefCounted<URLRequestJob>,
   virtual bool IsCachedContent() const;
   virtual int64 GetByteReadCount() const;
   virtual int GetResponseCode() const;
-  virtual int GetInputStreamBufferSize() const;
   virtual void RecordPacketStats(StatisticSelector statistic) const;
 
   // Returns the socket address for the connection.
@@ -304,9 +303,6 @@ class URLRequestJob : public base::RefCounted<URLRequestJob>,
   bool is_compressed_;
 
  private:
-  // Size of filter input buffers used by this class.
-  static const int kFilterBufSize;
-
   // When data filtering is enabled, this function is used to read data
   // for the filter.  Returns true if raw data was read.  Returns false if
   // an error occurred (or we are waiting for IO to complete).