diff options
| author | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-30 22:04:20 +0000 |
|---|---|---|
| committer | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-30 22:04:20 +0000 |
| commit | 17e6dccecce21c979c2a2e69d2f0774f51489a3a (patch) | |
| tree | 302e328f1e843b9fd7a441b7ba164c866026b98d /net | |
| parent | 67bf67fe0f783d760b2bfae5ac1be9a54da83b19 (diff) | |
| download | chromium_src-17e6dccecce21c979c2a2e69d2f0774f51489a3a.zip chromium_src-17e6dccecce21c979c2a2e69d2f0774f51489a3a.tar.gz chromium_src-17e6dccecce21c979c2a2e69d2f0774f51489a3a.tar.bz2 | |
Don't use an assignment as a truth value.
Original review: http://codereview.chromium.org/159653
R=darin,pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22106 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/base/net_util.cc | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/net/base/net_util.cc b/net/base/net_util.cc index d51181c..7afd4c5 100644 --- a/net/base/net_util.cc +++ b/net/base/net_util.cc @@ -634,14 +634,13 @@ bool IsIDNComponentSafe(const char16* str, // the remainder. component_characters.removeAll(common_characters); - bool safe = false; std::string languages_list(WideToASCII(languages)); StringTokenizer t(languages_list, ","); while (t.GetNext()) { - if ((safe = IsComponentCoveredByLang(component_characters, t.token()))) - break; + if (IsComponentCoveredByLang(component_characters, t.token())) + return true; } - return safe; + return false; } // Converts one component of a host (between dots) to IDN if safe. The result |