diff options
author | mrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-07 22:14:06 +0000 |
---|---|---|
committer | mrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-07 22:14:06 +0000 |
commit | 1f4da86c4928ccdc3c6f626d52a109b2f5da21d1 (patch) | |
tree | 4801b62f1d3d41f9c311e22414d4665e854ffeba /net | |
parent | 45aabf3d4a30248626533da0416bd082a13a0364 (diff) | |
download | chromium_src-1f4da86c4928ccdc3c6f626d52a109b2f5da21d1.zip chromium_src-1f4da86c4928ccdc3c6f626d52a109b2f5da21d1.tar.gz chromium_src-1f4da86c4928ccdc3c6f626d52a109b2f5da21d1.tar.bz2 |
Refactor menu window height, position, and presence of scrolling arrows code out of configureWindow and into a new adjustWindowForHeight: method. Call this method when adding or removing bookmark nodes to the menu, such as for dropping or pasting. When adjusting the button widths consider the best cell width, which may be less than the current button width, so that folder menus can shrink as well as grow. When adding the first bookmark to an empty folder remove the '(empty)' placeholder and when removing the last real bookmark from a folder insert the '(empty)' placeholder.
BUG=42868,43227
TEST=In addition to attempting to recreate the problems as described in the bug reports: 1) Add (by dragging in or pasting) a new bookmark to a folder which is on the edge of being too big and needing to scroll and verify that it does become scrollable, 2) remove a bookmark (by cutting or deleting) from the folder which just became scrollable and verify that it is no longer scrollable, 3) create a new, empty folder and verify that it shows '(empty)' , 4) add a bookmark (by dragging or pasting) to the newly created empty folder and verify that there is only one bookmark shown and that it is not the '(empty)' placeholder, and 5) remove the single bookmark just added to the folder (by cutting or deleting) and verify that the menu now shows the '(empty)' placeholder.
Review URL: http://codereview.chromium.org/2024004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46744 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions