diff options
| author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-21 06:20:07 +0000 |
|---|---|---|
| committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-21 06:20:07 +0000 |
| commit | 1ff3af9f59a44b0926789f169545ff4241440c3a (patch) | |
| tree | f3369eea783e86c4433143d187b89db4f1e3a1a4 /net | |
| parent | b89bc57c7f568dfa3a3d7a884d6bbb254fb49e49 (diff) | |
| download | chromium_src-1ff3af9f59a44b0926789f169545ff4241440c3a.zip chromium_src-1ff3af9f59a44b0926789f169545ff4241440c3a.tar.gz chromium_src-1ff3af9f59a44b0926789f169545ff4241440c3a.tar.bz2 | |
[Coverity] Pass-by-ref instead of value
CID=104690,104691
CID_COUNT=2
R=jar@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10857049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152515 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'net')
| -rw-r--r-- | net/spdy/spdy_credential_builder.cc | 5 | ||||
| -rw-r--r-- | net/spdy/spdy_credential_builder.h | 4 |
2 files changed, 5 insertions, 4 deletions
diff --git a/net/spdy/spdy_credential_builder.cc b/net/spdy/spdy_credential_builder.cc index af04eff..5dbc5af 100644 --- a/net/spdy/spdy_credential_builder.cc +++ b/net/spdy/spdy_credential_builder.cc @@ -26,7 +26,7 @@ std::vector<uint8> ToVector(base::StringPiece piece) { } // namespace // static -int SpdyCredentialBuilder::Build(std::string tls_unique, +int SpdyCredentialBuilder::Build(const std::string& tls_unique, SSLClientCertType type, const std::string& key, const std::string& cert, @@ -73,7 +73,8 @@ int SpdyCredentialBuilder::Build(std::string tls_unique, } // static -std::string SpdyCredentialBuilder::GetCredentialSecret(std::string tls_unique) { +std::string SpdyCredentialBuilder::GetCredentialSecret( + const std::string& tls_unique) { const char prefix[] = "SPDY CREDENTIAL ChannelID\0client -> server"; std::string secret(prefix, arraysize(prefix)); secret.append(tls_unique); diff --git a/net/spdy/spdy_credential_builder.h b/net/spdy/spdy_credential_builder.h index c8893c1..278d239 100644 --- a/net/spdy/spdy_credential_builder.h +++ b/net/spdy/spdy_credential_builder.h @@ -19,7 +19,7 @@ struct SpdyCredential; // SPDY CREDENTIAL frames. class NET_EXPORT_PRIVATE SpdyCredentialBuilder { public: - static int Build(std::string tls_unique, + static int Build(const std::string& tls_unique, SSLClientCertType type, const std::string& key, const std::string& cert, @@ -30,7 +30,7 @@ class NET_EXPORT_PRIVATE SpdyCredentialBuilder { friend class SpdyCredentialBuilderTest; // Returns the secret data to be signed as part of a credential frame. - static std::string GetCredentialSecret(std::string tls_unique); + static std::string GetCredentialSecret(const std::string& tls_unique); }; } // namespace net |